[Due for payment 2025-12-17] [$250] Reports-After deleting IOU, nothing to show is shown briefly before updating to default page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.-59-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://github.com/Expensify/Expensify/issues/521262
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Flip3, OS 15
App Component: Money Requests

Action Performed:

1.Go to https://staging.new.expensify.com/home
2.Login with new expensifail account
3.Go to reports page
4. Tap fab - create expense and complete the flow with 1:1 user
5.Select and delete the expense
6. Note nothing to show is shown briefly before updating to default reports page

Expected Result:

After deleting IOU, nothing to show is must not be shown briefly before updating to default reports page

Actual Result:

After deleting IOU, nothing to show is shown briefly before updating to default reports page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7006987_1763436064965.Recording__2558.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993526007669498494
• Upwork Job ID: 1993526007669498494
• Last Price Increase: 2025-11-26

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting IOU, nothing to show is shown briefly before updating to default reports page.

What is the root cause of that problem?

1. When EmptySearchView is rendered, it relies on the hasResults prop to determine whether to display emptyResults or emptyReportResults state:
   

   App/src/pages/Search/EmptySearchView.tsx

   Lines 337 to 350 in f34c0e3

   	case CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT:
   	if (hasResults) {
   	return {
   	...defaultViewItemHeader,
   	title: translate('search.searchResults.emptyResults.title'),
   	subtitle: translate('search.searchResults.emptyResults.subtitle'),
   	};
   	}
   	if (!hasResults || !hasExpenseReports) {
   	return {
   	...defaultViewItemHeader,
   	title: translate('search.searchResults.emptyReportResults.title'),
   	subtitle: translate(hasSeenTour ? 'search.searchResults.emptyReportResults.subtitleWithOnlyCreateButton' : 'search.searchResults.emptyReportResults.subtitle'),
   	buttons: [

2. The hasResults value is based on searchResults?.search?.hasResults, which is only updated by the Search API.
   So when a report is deleted, EmptySearchView is shown because visibleDataLength === 0, but searchResults?.search?.hasResults still returns true while waiting for the API response:
   

   App/src/components/Search/index.tsx

   Line 901 in f34c0e3

   hasResults={searchResults?.search?.hasResults}

What changes do you think we should make in order to solve the problem?

Add checks for hasExpenseReports and hasTransactions:

App/src/pages/Search/EmptySearchView.tsx

Line 338 in f34c0e3

if (hasResults) {

    if (hasResults && (!isDefaultExpenseReportsQuery(queryJSON) || hasExpenseReports)) {

App/src/pages/Search/EmptySearchView.tsx

Line 392 in f34c0e3

if (hasResults) {

    if (hasResults && (!isDefaultExpensesQuery(queryJSON) || hasTransactions)) {

NOTE: isDefaultExpenseReportsQuery is a function similar to isDefaultExpensesQuery, but it checks against the type CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT

What alternative solutions did you explore? (Optional)

We should add a condition to check that visibleDataLength > 0.

App/src/components/Search/index.tsx

Lines 896 to 904 in f34c0e3

	return (
	<View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
	<EmptySearchView
	similarSearchHash={similarSearchHash}
	type={type}
	hasResults={searchResults?.search?.hasResults}
	/>
	</View>
	);

let hasResults = searchResults?.search?.hasResults;
if (isDefaultExpensesQuery(queryJSON) || isDefaultExpenseReportsQuery(queryJSON)) {
    hasResults &&= visibleDataLength > 0;
}
return (
    <View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
        <EmptySearchView
            similarSearchHash={similarSearchHash}
            type={type}
            hasResults={hasResults}
        />
    </View>
);

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993526007669498494

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[strepanier03]

Able to repro, moving forward.

[eh2077]

I think we can go with @dmkt9 's proposal - fix the issue by tightening the condition to show emptyResults page.

🎀👀🎀 C+ reviewed