Merged
Conversation
… for the enums that was touched in this PR)
Member
|
Sorry for bringing the bad news but there are some merge conflicts with #457 |
Member
Author
Story of my day @sbernauer... will fix and request approval |
Member
Author
@nightkr maybe in a new PR? I'd like to get this in now so others can build off of it as the merge conflicts are getting tricky to resolve. |
nightkr
reviewed
Jan 23, 2024
Co-authored-by: Natalie <nat.roijezon@stackable.tech>
``` This is version 0.0.0-dev, built for x86_64-unknown-linux-gnu by rustc 1.75.0 (82e1608df 2023-12-21) (built from a source tarball) at Wed, 24 Jan 2024 08:59:02 +0000 ```
This was referenced Jan 24, 2024
Techassi
approved these changes
Feb 2, 2024
Member
Techassi
left a comment
There was a problem hiding this comment.
Great work, really like how you cleaned up the errors and the different builders.
Member
Author
|
Merging, even though kuttl tests aren't working yet. We will fix forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Definition of Done Checklist