Conversation
razvan
previously approved these changes
Jan 22, 2024
Member
razvan
left a comment
There was a problem hiding this comment.
nice. maybe an entry in the change log would be nice, even if it's not user facing.
razvan
approved these changes
Jan 22, 2024
Contributor
Author
|
I would argue that these externally invisible changes don't make sense to add, "refactored |
Member
|
This is probably a discipline vs. common sense discussion. I can get behind both arguments, just mentioned it because it's a checkbox for the reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #456.
This is intended to solve two things:
MergedConfigcontaining the union of all roles' options, making it unclear which fields available when (and the especially comical case whereresourcesexists in all variants... but still has a separate accessor method for each).Instead, this PR delegates actually-common options to the new
struct CommonNodeConfigand introduces a newenum AnyNodeConfigwhich users can explicitly downcast from to access role-specific options. Common options are accessible immediately becauseAnyNodeConfigderefs toCommonNodeConfig.This PR replaces all uses of
&dyn MergedConfigwith&AnyNodeConfigto minimize impact. In the future, it's intended that new code that is only relevant for a single role should use that role's config type directly.Definition of Done Checklist