Skip to content

fix: Include hdfs principal names in discovery ConfigMap#451

Merged
sbernauer merged 4 commits intomainfrom
fix/kerberos-discovery-2
Jan 12, 2024
Merged

fix: Include hdfs principal names in discovery ConfigMap#451
sbernauer merged 4 commits intomainfrom
fix/kerberos-discovery-2

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Jan 9, 2024

Description

Replaces #424
Fixes #419

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [x] Proper release label has been added

Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer
Copy link
Copy Markdown
Member Author

Thanks for the review!

@sbernauer sbernauer added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 1e4f5a2 Jan 12, 2024
@sbernauer sbernauer deleted the fix/kerberos-discovery-2 branch January 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Discovery configmap incomplete when Kerberos is enabled

5 participants