SG-34199 Comment typing annotation breaks Python 2 compatibility#320
Merged
Conversation
We pull `shotgun_api3` directly for deployment here at TTF. We have some old shows still using Maya2019 (and thereby Python 2). This addition of hinting annotations breaks import of your packages. If it's intentional, and you are dropping Py2 support, then disregard this PR. In that case, we'll have to lock our release for our Py2 deployments (while we have them).
…g when the variable does not exist instead of the macro unchanged https://learn.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#macro-syntax-variables
… sometimes needs an empty value
julien-lang
force-pushed
the
ticket/SG-34199-fix-regression
branch
from
29b82b3 to
befd76a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #318