Skip to content

SG-34199 Comment typing annotation breaks Python 2 compatibility #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julien-lang merged 3 commits into from
Jan 11, 2024
Merged

SG-34199 Comment typing annotation breaks Python 2 compatibility #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bec034
#comment typing annotation breaks Python 2 compatibility
slackba Jan 4, 2024
6cf105e
Switchng variable syntax from macro to template to get an empty strin…
julien-lang Jan 10, 2024
befd76a
Remove example server_url value from config because is used by CI and…
julien-lang Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions azure-pipelines-templates/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ jobs:
# Pass the values needed to authenticate with the Shotgun site and create some entities.
# Remember, on a pull request from a client or on forked repos, those variables
# will be empty!
SG_SERVER_URL: $(ci_site)
SG_SCRIPT_NAME: $(ci_site_script_name)
SG_API_KEY: $(ci_site_script_key)
SG_SERVER_URL: ${{ variables.ci_site }}
SG_SCRIPT_NAME: ${{ variables.ci_site_script_name }}
SG_API_KEY: ${{ variables.ci_site_script_key }}
# The unit tests manipulate the user and project during the tests, which can cause collisions,
# so sandbox each build variant.
# Ideally, we would use the agent name here. The problem is that the agent name is in a build
Expand Down
3 changes: 2 additions & 1 deletion shotgun_api3/shotgun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3273,7 +3273,8 @@ def user_subscriptions_read(self):

return self._call_rpc("user_subscriptions_read", None)

def user_subscriptions_create(self, users: list):
def user_subscriptions_create(self, users):
# type: (list[dict[str, Union[str, list[str], None]) -> bool
"""
Assign subscriptions to users.

Expand Down
2 changes: 1 addition & 1 deletion tests/example_config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# Full url to the ShotGrid server server
# e.g. https://my-site.shotgrid.autodesk.com
# be careful to not end server_url with a "/", or some tests may fail
server_url : http://0.0.0.0:3000
server_url :
# script name as key as listed in admin panel for your server
script_name : test script name
api_key : test script api key
Expand Down