Skip to content

SG-34199 #comment typing annotation breaks Python 2 compatibility#318

Closed
slackba wants to merge 1 commit into
shotgunsoftware:masterfrom
slackba:patch-1
Closed

SG-34199 #comment typing annotation breaks Python 2 compatibility#318
slackba wants to merge 1 commit into
shotgunsoftware:masterfrom
slackba:patch-1

Conversation

@slackba
Copy link
Copy Markdown
Contributor

@slackba slackba commented Jan 4, 2024

We pull shotgun_api3 directly for deployment here at TTF. We have some old shows still using Maya2019 (and thereby Python 2). This addition of hinting annotations breaks import of your packages. If it's intentional, and you are dropping Py2 support, then disregard this PR. In that case, we'll have to lock our release for our Py2 deployments (while we have them).

We pull `shotgun_api3` directly for deployment here at TTF. We have some old shows still using Maya2019 (and thereby Python 2). This addition of hinting annotations breaks import of your packages. If it's intentional, and you are dropping Py2 support, then disregard this PR. In that case, we'll have to lock our release for our Py2 deployments (while we have them).
@carlos-villavicencio-adsk carlos-villavicencio-adsk changed the title #comment typing annotation breaks Python 2 compatibility SG-34199 #comment typing annotation breaks Python 2 compatibility Jan 10, 2024
@julien-lang julien-lang self-requested a review January 10, 2024 19:09
@julien-lang
Copy link
Copy Markdown
Member

Hi @slackba, Thank you for reporting this issue!

This regression was not intentional so we are going to merge this change. For CI reasons, I had to create a clone PR: #320.

However, we are going to remove the compatibility with Python 2 in a few months. For more information about this, please read this announcement: https://community.shotgridsoftware.com/t/important-notice-for-end-of-april-2024-reminder-end-of-support-for-python-2-7/.

Also, regarding Maya, we wanted to let you know that ShotGrid Toolkit/Python API no longer supports Maya 2019. The oldest supported version is Maya 2020. For more information about Engine Supported Versions, please refer to the following documentation: https://help.autodesk.com/view/SGDEV/ENU/?guid=SGD_si_integrations_engine_supported_versions_html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants