Restructure runscripts and related resources#181
Conversation
davidscn
left a comment
There was a problem hiding this comment.
Very nice! I guess your checklist keeps track of already checked run scripts and we can check tomorrow if everything works.
|
@davidscn ready for review! If you can easily run something with Nutils/FEniCS, please do. Other than than, any comments are welcome. Especially: did I forget anything? Is there anything in the documentation to fix? |
| cd "$1" | ||
| echo "--- Cleaning up CalculiX case in $(pwd)" | ||
| rm -fv ./*.cvg ./*.dat ./*.frd ./*.sta ./*.12d spooles.out | ||
| rm -fv ./*.cvg ./*.dat ./*.frd ./*.sta ./*.12d spooles.out dummy |
There was a problem hiding this comment.
This dummy is generated at least in the heat exchanger CalculiX case, I have no idea where it comes from.
| set -e -u | ||
| cd "$1" | ||
| echo "--- Cleaning up Nutils case in $(pwd)" | ||
| rm -fv ./*.vtk |
There was a problem hiding this comment.
Now we delete all the VTK files inside Nutils cases. I guess not much can go wrong.
davidscn
left a comment
There was a problem hiding this comment.
A two more comments:
- the OpenFOAM run ends for me with the following message
../../tools/run-openfoam.sh: 17: .: openfoam-remove-empty-dirs.sh: not found - I created the deal.II run script as symbolic link similar to our cleaning scripts. Do you want to keep it in case of OpenFOAM as it currently is?
I will adjust the quickstart in #145 and we can check the remaining parts during the coding days :)
Good catch, I fixed it by moving the cleaning part into
In the way I see it, we cannot do this for OpenFOAM: some cases have different preparation steps and for all of them I create a named
Then I don't wait for the Quickstart :). |
|
This PR is ready from my side. I also looked at the diff and it is as intended. Are there further comments or things to check? |
Similarly to #169 and #166, this collects all the run scripts into common files, to reduce duplication.
.gitignorefiles, so this also rouches aspects of Inconsistent .gitignore among cases #87.run.shor aclean.shthat was missing. I guess that some of the cases are not yet in the fully restructured form, but these are elements we need anyway. I have not checked if the runscripts run. I also softened a bit an existing.gitignorefile for a FEniCS case.clean_nutilsto remove all./*.vtkfiles. Not tested.All scripts have been validated with shellcheck.
Before merging:
0.orig(moved to0in most cases) . What happens when we use the cleaning scripts of the foundation version?After merging: