Conversation
MakisH
commented
Apr 11, 2021
uekerman
reviewed
Apr 12, 2021
Member
uekerman
left a comment
There was a problem hiding this comment.
README looks good. Only minor things below.
You added four pngs for the pipe. On purpose?
Member
Author
Yes, to showcase that all these combinations work. Would there be a reason to remove them? (details, but let's decide) |
Member
If we don't show them somewhere, we might forget why we have them. |
Member
Author
Good point, I removed them. |
uekerman
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the fluid-fluid coupling tutorials from the OpenFOAM adapter.
Reviewers:
precice-config.xmlas with the previous 2xpimpleFoam (the compressible one was using parallel-implicit and had more relaxed convergence measures).Before merging:
After merging: