Release for fenics adapter v1.0.0#132
Conversation
This reverts commit a178d1c.
Update FEniCS cases data initialization
Use SegregatedRBFInterpolationExpression for partitioned heat equation tutorial.
…expression Removes interpolation_type from all fenics adapter config files.
Output frequency of heat.py must match frequency of OpenFOAM Fluid case. Compare writeInterval in controlDict (https://github.com/precice/openfoam-adapter/blob/develop/tutorials/CHT/flow-over-plate/buoyantPimpleFoam-laplacianFoam/Fluid/system/controlDict).
Ensures compatibility with changes introduced in precice/fenics-adapter@fef80b7
Replace deal.II cylinderFlap tutorial with fsi3
Change FEniCS tutorials to handle new initialization signature of FEniCS-Adapter
Co-authored-by: uekerman <benjamin.uekermann@gmail.com> Co-authored-by: MakisH <chourdak@in.tum.de>
* draft two perpendicular flap case * Allclean Allrun adapted to two flaps * name changed to solid1_mesh * README update and deal.ii binaris removed * minor changes * name changed to Fluid1-mesh... * delted deal.ii binaries * modified gitignore * minor changes * update nonlinear prm files * gitignore thingie * minor changes * runSolid added * just trying * first wiki draft * wiki draft * wiki * minor changes * working on the mesh * working with smaller velocity * png added * more images * images * images * changes about dealii * english corrections * allclean removes precice-output folder * updated documentation * flap location given as double * wiki content moved to readme file * precice-config.xml formatted using new version Co-authored-by: homspons <ge35joj>
* Adding 2D perpendicular flap FSI tutorial with SU2-FEniCS Co-authored-by: Benjamin Rüth <benjamin.rueth@tum.de>
* Modifying all FEniCS based tutorials to be compatible with parallel design of FEniCS-Adapter Co-authored-by: BenjaminRueth <benjamin.rueth@tum.de>
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
This still merges directly from a specific branch to master. What we want is to merge develop to master.
So no release branch? Also ok. |
Ah, it was not clear to me that this is a release branch that has everything already on develop (we have not yet standardized this). Then this is fine, I will have a look later today. |
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
The following two tutorials produce errors on the OpenFOAM side:
FSI/cylinderFlap/OpenFOAM-FEniCSFSI/flap_perp/OpenFOAM-FEniCS
Rest everything works, confirmed by manual checks 👍
|
Closing this one in favor of #124. We actually want to give the approach in #124 a chance in order to find out whether it is possible to release only a part of the tutorials without driving everybody crazy. This PR (#132) is git-wise much more simple than #124, but does not meet the requirement "only release FEniCS stuff". |
6 participants
This is now a "real" release originating from the discussion in #124.
This release is published to provide a version of the tutorials that is compatible with the upcoming v1.0.0 release of the fenics-adapter.
I will add a tag
fenics-adapter-v1.0.0as soon as this PR is merged. Similar to here.