Skip to content

Update development dependencies to Dash 2.x#179

Closed
akx wants to merge 2 commits into
plotly:masterfrom
akx:dev-dep-bump
Closed

Update development dependencies to Dash 2.x#179
akx wants to merge 2 commits into
plotly:masterfrom
akx:dev-dep-bump

Conversation

@akx

@akx akx commented Jul 14, 2022

Copy link
Copy Markdown

About

I noticed that pip install -e . installed Dash 2.x, and then installing requirements as per CONTRIBUTING.md downgraded Dash to 1.x, which didn't quite seem right.

Description of changes

  • remove the Python 2.x biopython dependency; the package isn't expected to run on Python 2
  • bump Dash dependency to any 2.x version (2.0 was released in Sep 2021)

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

* remove the Python 2.x biopython dependency; the package isn't expected to run on Python 2
* bump Dash dependency to any 2.x version (2.0 was released in Sep 2021) to match setup.py pinning
@akx
akx requested a review from alexcjohnson as a code owner July 14, 2022 09:28
@akx akx mentioned this pull request Sep 8, 2022
6 tasks
@alexcjohnson

Copy link
Copy Markdown
Collaborator

Done in #193 and #202 - thanks @akx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants