Skip to content

Upgrade to react-cytoscapejs 2#183

Closed
akx wants to merge 3 commits into
plotly:masterfrom
akx:react-cytoscape-2
Closed

Upgrade to react-cytoscapejs 2#183
akx wants to merge 3 commits into
plotly:masterfrom
akx:react-cytoscape-2

Conversation

@akx

@akx akx commented Sep 6, 2022

Copy link
Copy Markdown

About

I checked that the Webpack builds pass, hoping that CI here would do the rest.

Cc

Description of changes

See above.

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

See plotly/react-cytoscapejs#99 for the discussion around react-cytoscapejs 2.

* remove the Python 2.x biopython dependency; the package isn't expected to run on Python 2
* bump Dash dependency to any 2.x version (2.0 was released in Sep 2021) to match setup.py pinning
@akx
akx requested a review from alexcjohnson as a code owner September 6, 2022 13:40
@alexcjohnson

Copy link
Copy Markdown
Collaborator

Thanks @akx. Looks like there are some build issues on CI... if you're motivated to dig in you're more than welcome, I've updated the permissions so it should work fine from your fork now, but I'm also happy to let this one wait a bit until someone from Plotly gets a chance to poke around here.

@akx
akx force-pushed the react-cytoscape-2 branch from 4b3e1c2 to 6d3f625 Compare September 8, 2022 07:26
@akx

akx commented Sep 8, 2022

Copy link
Copy Markdown
Author

@alexcjohnson Well, it worked for exactly one build... 😁

I think #179 is related here; since pip install has been set to --quiet I can't verify which version of dash is exactly being used, but it's obviously not one with plotly/dash#1995 in, since the one build failed with

  File "/home/circleci/project/venv/lib/python3.7/site-packages/dash/dash.py", line 22, in <module>
    from werkzeug.debug.tbtools import get_current_traceback
ImportError: cannot import name 'get_current_traceback' from 'werkzeug.debug.tbtools' (/home/circleci/project/venv/lib/python3.7/site-packages/werkzeug/debug/tbtools.py)

@alexcjohnson

Copy link
Copy Markdown
Collaborator

Yeah weird. Feel free to remove --quiet - and thanks for the nudge on #179

@alexcjohnson

Copy link
Copy Markdown
Collaborator

Done in #193 - thanks @akx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants