Upgrade to react-cytoscapejs 2#183
Closed
akx wants to merge 3 commits into
Closed
Conversation
* remove the Python 2.x biopython dependency; the package isn't expected to run on Python 2 * bump Dash dependency to any 2.x version (2.0 was released in Sep 2021) to match setup.py pinning
Collaborator
|
Thanks @akx. Looks like there are some build issues on CI... if you're motivated to dig in you're more than welcome, I've updated the permissions so it should work fine from your fork now, but I'm also happy to let this one wait a bit until someone from Plotly gets a chance to poke around here. |
akx
force-pushed
the
react-cytoscape-2
branch
from
September 8, 2022 07:26
4b3e1c2 to
6d3f625
Compare
Author
|
@alexcjohnson Well, it worked for exactly one build... 😁 I think #179 is related here; since |
Collaborator
|
Yeah weird. Feel free to remove |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
I checked that the Webpack builds pass, hoping that CI here would do the rest.
Cc
Description of changes
See above.
Pre-Merge checklist
npm run build:all.Reference Issues
See plotly/react-cytoscapejs#99 for the discussion around react-cytoscapejs 2.