Upgrade versions - #202
Merged
Merged
Conversation
added 12 commits
January 24, 2024 09:19
emilykl
approved these changes
Jan 24, 2024
emilykl
left a comment
Contributor
There was a problem hiding this comment.
Tested on my machine with npm install -> npm run build:all followed by trying out several demos in the browser, including usage_cy_leaflet_aio.py. All working for me!
I'll defer to @alexcjohnson for the specifics of the CICD and Javascript conventions.
alexcjohnson
approved these changes
Jan 24, 2024
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
💃 Fantastic! Just two small comments then we're ready to merge 🎉
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
General update of versions.
Description of changes
requirements.txtandtests/requirements.txtas the minimum python version is now 3.8.dash-leaflettotests/requirements.txtPre-Merge checklist
npm run build:all.