Skip to content

Upgrade versions - #202

Merged
Farkites merged 20 commits into
masterfrom
upgrade-python-version
Jan 25, 2024
Merged

Upgrade versions#202
Farkites merged 20 commits into
masterfrom
upgrade-python-version

Conversation

@Farkites

@Farkites Farkites commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

About

General update of versions.

Description of changes

  • Upgraded minimum python version of 3.8
    • Removed conditional versions in requirements.txt and tests/requirements.txt as the minimum python version is now 3.8.
    • Upgraded python version for CICD to 3.8.18
  • Updated all JS dependencies.
  • Fixed lint errors introduced in Add CyLeaflet AIO component #200
  • Added dash-leaflet to tests/requirements.txt

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

@Farkites
Farkites requested review from cleaaum and emilykl January 23, 2024 11:49

@cleaaum cleaaum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me! 💃

Comment thread package.json Outdated
Comment thread package.json Outdated

@emilykl emilykl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine with npm install -> npm run build:all followed by trying out several demos in the browser, including usage_cy_leaflet_aio.py. All working for me!

I'll defer to @alexcjohnson for the specifics of the CICD and Javascript conventions.

Comment thread src/lib/components/Cytoscape.react.js Outdated
Comment thread dash_cytoscape/package.json Outdated

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Fantastic! Just two small comments then we're ready to merge 🎉

@Farkites
Farkites merged commit 43433b0 into master Jan 25, 2024
@alexcjohnson
alexcjohnson deleted the upgrade-python-version branch January 25, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants