ROSAENG-60066: Add Prow e2e jobs for AVO, MUO, and OAO - #82185
Conversation
Add rosa-sts-e2e presubmit and promotion periodics for aws-vpce-operator, managed-upgrade-operator, and ocm-agent-operator. Same pattern as CAMO (PR openshift#82101).
openshift-ci-robot
added
the
jira/valid-reference
|
@dustman9000: This pull request references ROSAENG-60066 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
WalkthroughThe three operator CI configurations now define release build inputs and OCP 4.22 CI candidates, and add optional or scheduled ROSA STS E2E jobs using the cluster lease workflow. ChangesOperator CI and ROSA STS E2E
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant ProwJob
participant RosaClusterLeaseE2E
participant OperatorImages
participant Cluster
ProwJob->>RosaClusterLeaseE2E: start workflow with job environment
RosaClusterLeaseE2E->>OperatorImages: use operator and PKO images
RosaClusterLeaseE2E->>Cluster: provision leased cluster and apply operator CRDs
Cluster-->>RosaClusterLeaseE2E: return E2E result
RosaClusterLeaseE2E-->>ProwJob: publish job status
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
A total of 27 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main.yaml`:
- Around line 77-131: Run make update to regenerate and validate Prow
configuration and commit the generated outputs for the jobs in
ci-operator/config/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main.yaml
lines 77-131,
ci-operator/config/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master.yaml
lines 72-126, and
ci-operator/config/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master.yaml
lines 72-129.
- Line 79: Update the run_if_changed patterns in
ci-operator/config/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main.yaml:79-79,
ci-operator/config/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master.yaml:74-74,
and
ci-operator/config/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master.yaml:74-74
to include build/Dockerfile and deploy_pko/.*, preserving all existing triggers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 9cc2da3c-6e77-4e5b-9aa8-11439c1067ee
⛔ Files ignored due to path filters (9)
ci-operator/jobs/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (3)
ci-operator/config/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main.yamlci-operator/config/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master.yamlci-operator/config/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master.yaml
| skip_if_only_changed: ^(?:\.tekton|\.github)|\.md$|^(?:\.gitignore|OWNERS|LICENSE)$ | ||
| - as: rosa-sts-e2e | ||
| optional: true | ||
| run_if_changed: ^(test/e2e/.*|pkg/.*|api/.*|cmd/.*|deploy/.*|go\.mod|go\.sum)$ |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Trigger E2E when packaged artifacts change.
The filters omit build/Dockerfile (the operator image) and deploy_pko/** (the PKO package), so changes to either can merge without exercising the ROSA E2E job.
ci-operator/config/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main.yaml#L79-L79: includebuild/Dockerfileanddeploy_pko/.*.ci-operator/config/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master.yaml#L74-L74: includebuild/Dockerfileanddeploy_pko/.*.ci-operator/config/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master.yaml#L74-L74: includebuild/Dockerfileanddeploy_pko/.*.
Proposed pattern
- run_if_changed: ^(test/e2e/.*|pkg/.*|api/.*|cmd/.*|deploy/.*|go\.mod|go\.sum)$
+ run_if_changed: ^(test/e2e/.*|pkg/.*|api/.*|cmd/.*|deploy/.*|deploy_pko/.*|build/Dockerfile|go\.mod|go\.sum)$📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| run_if_changed: ^(test/e2e/.*|pkg/.*|api/.*|cmd/.*|deploy/.*|go\.mod|go\.sum)$ | |
| run_if_changed: ^(test/e2e/.*|pkg/.*|api/.*|cmd/.*|deploy/.*|deploy_pko/.*|build/Dockerfile|go\.mod|go\.sum)$ |
📍 Affects 3 files
ci-operator/config/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main.yaml#L79-L79(this comment)ci-operator/config/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master.yaml#L74-L74ci-operator/config/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master.yaml#L74-L74
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main.yaml`
at line 79, Update the run_if_changed patterns in
ci-operator/config/openshift/aws-vpce-operator/openshift-aws-vpce-operator-main.yaml:79-79,
ci-operator/config/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master.yaml:74-74,
and
ci-operator/config/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master.yaml:74-74
to include build/Dockerfile and deploy_pko/.*, preserving all existing triggers.
There was a problem hiding this comment.
Intentional. The run_if_changed filter matches the same pattern used by RMO and CAMO. build/Dockerfile changes are covered by the existing images presubmit. deploy_pko/ changes are caught by the deploy/.* pattern in the regex. The presubmit is optional and the promotion periodics run on every SAPM deploy regardless of file changes.
There was a problem hiding this comment.
@dustman9000, agreed on build/Dockerfile: the existing image presubmit covers that intentionally, so I’ll drop that part of the concern.
One correction: deploy/.* does not match deploy_pko/...; the slash is literal and the regex is anchored. Since deploy_pko is copied into the operator-pko image, changes there still bypass the optional E2E presubmit. Please add deploy_pko/.* if those changes should exercise this job.
|
/pj-rehearse pull-ci-openshift-managed-upgrade-operator-master-rosa-sts-e2e pull-ci-openshift-ocm-agent-operator-master-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-aws-vpce-operator-main-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-ocm-agent-operator-master-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-aws-vpce-operator-main-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-aws-vpce-operator-main-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-aws-vpce-operator-main-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-aws-vpce-operator-main-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmeng, dustman9000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dustman9000: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add rosa-sts-e2e presubmit and promotion periodics for aws-vpce-operator, managed-upgrade-operator, and ocm-agent-operator. Same pattern as CAMO (PR openshift#82101).
3 participants
Summary
Add rosa-sts-e2e presubmit and promotion periodic jobs for three operators:
Same pattern as CAMO (PR #82101): dockerfile_literal images for operator-pko and operator-e2e, rosa-cluster-lease-e2e-workflow, cluster profile rosa-e2e-01.
Companion boilerplate PRs (pending): adds gangway-bridge-template.yml to each operator repo.
Jira: https://redhat.atlassian.net/browse/ROSAENG-60066
Test plan
Summary by CodeRabbit
Adds ROSA STS E2E presubmit and promotion periodic jobs for the AWS VPCE, Managed Upgrade, and OCM Agent operators.
operator-pkoandoperator-e2eimages.rosa-e2e-01profile.OPERATOR_NAMESPACEoverride.#rosa-prow-info.