fix: add arm64 capability to tests - #82025
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughGovernance policy framework CI configurations now require ChangesGovernance policy framework CI
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
/pj-rehearse abort |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse abort |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
cb5d242 to
1110329
Compare
|
/pj-rehearse |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml`:
- Around line 35-37: Update the arm64 test configuration in
stolostron-governance-policy-framework-release-5.0.yaml to use cluster build07
instead of build06, keeping the capabilities value unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 09d709d2-3c6a-4789-8645-1c45d783015b
⛔ Files ignored due to path filters (9)
ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.11-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.12-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.13-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.15-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (9)
ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-main.yamlci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.11.yamlci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.12.yamlci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.13.yamlci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.14.yamlci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.15.yamlci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.16.yamlci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.17.yamlci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml
🚧 Files skipped from review as they are similar to previous changes (8)
- ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.15.yaml
- ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.12.yaml
- ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.13.yaml
- ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.14.yaml
- ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.11.yaml
- ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.16.yaml
- ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.17.yaml
- ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-main.yaml
| capabilities: | ||
| - arm64 | ||
| cluster: build06 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '--- target file excerpt ---'
sed -n '1,120p' ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml
echo
echo '--- search arm64/build06/build07 in related config ---'
rg -n "arm64|build06|build07" ci-operator/config/stolostron/governance-policy-framework -g '*.yaml' -g '*.yml'
echo
echo '--- nearby release configs in same org/repo ---'
fd -a 'stolostron-governance-policy-framework-release-5.0.yaml|stolostron-governance-policy-framework-release-*.ya?ml' ci-operator/config/stolostron/governance-policy-frameworkRepository: openshift/release
Length of output: 5991
Use build07 for this arm64 test
ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml is the only release config in this repo family still using cluster: build06 for capabilities: [arm64]; the matching configs use build07 instead.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml`
around lines 35 - 37, Update the arm64 test configuration in
stolostron-governance-policy-framework-release-5.0.yaml to use cluster build07
instead of build06, keeping the capabilities value unchanged.
Source: Coding guidelines
There was a problem hiding this comment.
cluster: is temporary - I arbitrarily chose the same cluster as the one used to build images. The previous rehearsals kept using build04, which doesn't support arm64. Not sure if there is a better way to trigger a 'reselection' of clusters without specifying a cluster
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '--- capability and cluster selection documentation/references ---'
rg -n -i -C 3 'capabilities:|capabilit(y|ies)|rehearse|cluster.*select|select.*cluster|cluster:' \
README.md docs ci-operator core-services 2>/dev/null || true
echo
echo '--- files with candidate documentation names ---'
fd -a -i '.*(capabilit|ci-operator|clusterpool|rehearse).*' . \
-E .git -E vendor -E node_modules | head -200
echo
echo '--- current config family capability/cluster declarations ---'
rg -n -C 2 '^\s*(capabilities:|cluster:)|^\s*-\s*arm64\s*$' \
ci-operator/config/stolostron/governance-policy-framework -g '*.yaml' -g '*.yml'Length of output: 201195
@jan-law The search confirms that capabilities: [arm64] is the normal mechanism for declaring the requirement, but it did not uncover a documented user-facing way to force an existing rehearsal to reselect its build cluster.
It also shows the related jobs are pinned to different clusters (build07 for release branches and build09 on main), so that pattern does not make build07 a requirement. Keeping the temporary build06 pin to get the rehearsal onto an arm64-capable cluster is reasonable.
🧠 Learnings used
Learnt from: dustman9000
Repo: openshift/release PR: 80929
File: ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-production.yaml:31-39
Timestamp: 2026-06-24T02:25:16.245Z
Learning: In the openshift/release repo, when a PR makes structural changes to CI operator config (e.g., adding/renaming tests, changing the pre/post steps, or adding allow_best_effort_post_steps), require that the contributor regenerated the downstream Prow job definitions/metadata by running exactly: `make registry-metadata && make ci-operator-config && make jobs`. If the contributor confirms those commands were run successfully and the relevant CI checks passed, then treat the regeneration requirement as satisfied for review purposes.
Learnt from: gcs278
Repo: openshift/release PR: 80171
File: ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master.yaml:156-168
Timestamp: 2026-07-08T01:52:09.228Z
Learning: When reviewing PRs in openshift/release that may have affected CI Operator/Prow job generation (e.g., changes under ci-operator/config/**, ci-operator/step-registry/**, or infra-*.yaml), treat the repo’s CI presubmit checks as the authoritative signal. If reviewers suspect that regenerated Prow job files under ci-operator/jobs/** are missing, don’t automatically insist on manual/local regeneration via `make update`—especially if the author reports local tooling problems (containerized tooling via podman/docker). Instead, first confirm whether CI presubmits such as `pj-rehearse` and `ci-operator-config` validation fail for regeneration/consistency reasons, and align review feedback with what those checks enforce.
df5cc81 to
60a8afd
Compare
|
/pj-rehearse |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Janelle Law <jalaw@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/retest-required |
|
/pj-rehearse |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse skip The remaining errors are unrelated to this PR: |
|
@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/cc @dhaiducek |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, jan-law The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2e27541
into
openshift:main
|
@jan-law: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Janelle Law <jalaw@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Janelle Law <jalaw@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Follow up to #63142
The images appear to build successfully, but the e2e tests were placed on a cluster (build04) without arm64:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/stolostron_governance-policy-framework/1064/pull-ci-stolostron-governance-policy-framework-release-2.17-test-e2e-grc-framework/2077493608629407744
make updatedoes not select a new cluster after the capability was added.make updateclusterlabels. The bot should reassign clusters periodicallySummary by CodeRabbit
Updates the Stolostron Governance Policy Framework CI configuration in
ci-operator/config/stolostron/governance-policy-frameworkso thetest-e2e-grc-frameworke2e job is constrained to ARM64-capable clusters. The change adds acapabilities: [arm64]requirement to the e2e test step acrossstolostron-governance-policy-framework-main.yaml(targetingcluster: build09) and the release configsrelease-2.11throughrelease-2.16(each targetingcluster: build07), plusrelease-2.17(alsocluster: build07) andrelease-5.0(targetingcluster: build06).Also bumps the Go builder image tag to
go1.26-linuxinrelease-2.17andrelease-5.0.