Skip to content

fix: add arm64 capability to tests #82025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 22, 2026
Merged

fix: add arm64 capability to tests #82025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...g/stolostron/governance-policy-framework/stolostron-governance-policy-framework-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ resources:
tests:
- always_run: false
as: test-e2e-grc-framework
capabilities:
- arm64
cluster: build09
steps:
dependencies:
COMPONENT_IMAGE_REF: grc-policy-framework-tests
Expand Down
3 changes: 3 additions & 0 deletions ...tron/governance-policy-framework/stolostron-governance-policy-framework-release-2.11.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ resources:
memory: 200Mi
tests:
- as: test-e2e-grc-framework
capabilities:
- arm64
cluster: build07
steps:
dependencies:
COMPONENT_IMAGE_REF: grc-policy-framework-tests
Expand Down
3 changes: 3 additions & 0 deletions ...tron/governance-policy-framework/stolostron-governance-policy-framework-release-2.12.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ resources:
memory: 200Mi
tests:
- as: test-e2e-grc-framework
capabilities:
- arm64
cluster: build07
steps:
dependencies:
COMPONENT_IMAGE_REF: grc-policy-framework-tests
Expand Down
3 changes: 3 additions & 0 deletions ...tron/governance-policy-framework/stolostron-governance-policy-framework-release-2.13.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ resources:
memory: 200Mi
tests:
- as: test-e2e-grc-framework
capabilities:
- arm64
cluster: build07
steps:
dependencies:
COMPONENT_IMAGE_REF: grc-policy-framework-tests
Expand Down
3 changes: 3 additions & 0 deletions ...tron/governance-policy-framework/stolostron-governance-policy-framework-release-2.14.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ resources:
memory: 200Mi
tests:
- as: test-e2e-grc-framework
capabilities:
- arm64
cluster: build07
steps:
dependencies:
COMPONENT_IMAGE_REF: grc-policy-framework-tests
Expand Down
3 changes: 3 additions & 0 deletions ...tron/governance-policy-framework/stolostron-governance-policy-framework-release-2.15.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ resources:
memory: 200Mi
tests:
- as: test-e2e-grc-framework
capabilities:
- arm64
cluster: build07
steps:
dependencies:
COMPONENT_IMAGE_REF: grc-policy-framework-tests
Expand Down
3 changes: 3 additions & 0 deletions ...tron/governance-policy-framework/stolostron-governance-policy-framework-release-2.16.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ resources:
memory: 200Mi
tests:
- as: test-e2e-grc-framework
capabilities:
- arm64
cluster: build07
steps:
dependencies:
COMPONENT_IMAGE_REF: grc-policy-framework-tests
Expand Down
3 changes: 3 additions & 0 deletions ...tron/governance-policy-framework/stolostron-governance-policy-framework-release-2.17.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ resources:
memory: 200Mi
tests:
- as: test-e2e-grc-framework
capabilities:
- arm64
cluster: build07
steps:
dependencies:
COMPONENT_IMAGE_REF: grc-policy-framework-tests
Expand Down
3 changes: 3 additions & 0 deletions ...stron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ resources:
memory: 200Mi
tests:
- as: test-e2e-grc-framework
capabilities:
- arm64
cluster: build06
Comment on lines +35 to +37

@coderabbitai coderabbitai Bot Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '--- target file excerpt ---'
sed -n '1,120p' ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml

echo
echo '--- search arm64/build06/build07 in related config ---'
rg -n "arm64|build06|build07" ci-operator/config/stolostron/governance-policy-framework -g '*.yaml' -g '*.yml'

echo
echo '--- nearby release configs in same org/repo ---'
fd -a 'stolostron-governance-policy-framework-release-5.0.yaml|stolostron-governance-policy-framework-release-*.ya?ml' ci-operator/config/stolostron/governance-policy-framework

Repository: openshift/release

Length of output: 5991

Use build07 for this arm64 test
ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml is the only release config in this repo family still using cluster: build06 for capabilities: [arm64]; the matching configs use build07 instead.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml`
around lines 35 - 37, Update the arm64 test configuration in
stolostron-governance-policy-framework-release-5.0.yaml to use cluster build07
instead of build06, keeping the capabilities value unchanged.

Source: Coding guidelines

@jan-law jan-law Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster: is temporary - I arbitrarily chose the same cluster as the one used to build images. The previous rehearsals kept using build04, which doesn't support arm64. Not sure if there is a better way to trigger a 'reselection' of clusters without specifying a cluster

@coderabbitai coderabbitai Bot Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '--- capability and cluster selection documentation/references ---'
rg -n -i -C 3 'capabilities:|capabilit(y|ies)|rehearse|cluster.*select|select.*cluster|cluster:' \
  README.md docs ci-operator core-services 2>/dev/null || true

echo
echo '--- files with candidate documentation names ---'
fd -a -i '.*(capabilit|ci-operator|clusterpool|rehearse).*' . \
  -E .git -E vendor -E node_modules | head -200

echo
echo '--- current config family capability/cluster declarations ---'
rg -n -C 2 '^\s*(capabilities:|cluster:)|^\s*-\s*arm64\s*$' \
  ci-operator/config/stolostron/governance-policy-framework -g '*.yaml' -g '*.yml'

Length of output: 201195

@jan-law The search confirms that capabilities: [arm64] is the normal mechanism for declaring the requirement, but it did not uncover a documented user-facing way to force an existing rehearsal to reselect its build cluster.

It also shows the related jobs are pinned to different clusters (build07 for release branches and build09 on main), so that pattern does not make build07 a requirement. Keeping the temporary build06 pin to get the rehearsal onto an arm64-capable cluster is reasonable.

🧠 Learnings used 
Learnt from: dustman9000
Repo: openshift/release PR: 80929
File: ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-production.yaml:31-39
Timestamp: 2026-06-24T02:25:16.245Z
Learning: In the openshift/release repo, when a PR makes structural changes to CI operator config (e.g., adding/renaming tests, changing the pre/post steps, or adding allow_best_effort_post_steps), require that the contributor regenerated the downstream Prow job definitions/metadata by running exactly: `make registry-metadata && make ci-operator-config && make jobs`. If the contributor confirms those commands were run successfully and the relevant CI checks passed, then treat the regeneration requirement as satisfied for review purposes.

Learnt from: gcs278
Repo: openshift/release PR: 80171
File: ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master.yaml:156-168
Timestamp: 2026-07-08T01:52:09.228Z
Learning: When reviewing PRs in openshift/release that may have affected CI Operator/Prow job generation (e.g., changes under ci-operator/config/**, ci-operator/step-registry/**, or infra-*.yaml), treat the repo’s CI presubmit checks as the authoritative signal. If reviewers suspect that regenerated Prow job files under ci-operator/jobs/** are missing, don’t automatically insist on manual/local regeneration via `make update`—especially if the author reports local tooling problems (containerized tooling via podman/docker). Instead, first confirm whether CI presubmits such as `pj-rehearse` and `ci-operator-config` validation fail for regeneration/consistency reasons, and align review feedback with what those checks enforce.

steps:
dependencies:
COMPONENT_IMAGE_REF: grc-policy-framework-tests
Expand Down
4 changes: 3 additions & 1 deletion ...n/governance-policy-framework/stolostron-governance-policy-framework-main-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ presubmits:
branches:
- ^main$
- ^main-
cluster: build04
cluster: build09
context: ci/prow/test-e2e-grc-framework
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- build/Dockerfile.e2etest
labels:
capability/arm64: arm64
ci-operator.openshift.io/cluster: build09
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-stolostron-governance-policy-framework-main-test-e2e-grc-framework
Expand Down
4 changes: 3 additions & 1 deletion ...ance-policy-framework/stolostron-governance-policy-framework-release-2.11-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ presubmits:
branches:
- ^release-2\.11$
- ^release-2\.11-
cluster: build03
cluster: build07
context: ci/prow/test-e2e-grc-framework
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- build/Dockerfile.e2etest
labels:
capability/arm64: arm64
ci-operator.openshift.io/cluster: build07
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-stolostron-governance-policy-framework-release-2.11-test-e2e-grc-framework
Expand Down
4 changes: 3 additions & 1 deletion ...ance-policy-framework/stolostron-governance-policy-framework-release-2.12-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ presubmits:
branches:
- ^release-2\.12$
- ^release-2\.12-
cluster: build03
cluster: build07
context: ci/prow/test-e2e-grc-framework
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- build/Dockerfile.e2etest
labels:
capability/arm64: arm64
ci-operator.openshift.io/cluster: build07
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-stolostron-governance-policy-framework-release-2.12-test-e2e-grc-framework
Expand Down
4 changes: 3 additions & 1 deletion ...ance-policy-framework/stolostron-governance-policy-framework-release-2.13-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ presubmits:
branches:
- ^release-2\.13$
- ^release-2\.13-
cluster: build03
cluster: build07
context: ci/prow/test-e2e-grc-framework
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- build/Dockerfile.e2etest
labels:
capability/arm64: arm64
ci-operator.openshift.io/cluster: build07
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-stolostron-governance-policy-framework-release-2.13-test-e2e-grc-framework
Expand Down
4 changes: 3 additions & 1 deletion ...ance-policy-framework/stolostron-governance-policy-framework-release-2.14-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ presubmits:
branches:
- ^release-2\.14$
- ^release-2\.14-
cluster: build03
cluster: build07
context: ci/prow/test-e2e-grc-framework
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- build/Dockerfile.e2etest
labels:
capability/arm64: arm64
ci-operator.openshift.io/cluster: build07
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-stolostron-governance-policy-framework-release-2.14-test-e2e-grc-framework
Expand Down
4 changes: 3 additions & 1 deletion ...ance-policy-framework/stolostron-governance-policy-framework-release-2.15-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ presubmits:
branches:
- ^release-2\.15$
- ^release-2\.15-
cluster: build03
cluster: build07
context: ci/prow/test-e2e-grc-framework
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- build/Dockerfile.e2etest
labels:
capability/arm64: arm64
ci-operator.openshift.io/cluster: build07
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-stolostron-governance-policy-framework-release-2.15-test-e2e-grc-framework
Expand Down
4 changes: 3 additions & 1 deletion ...ance-policy-framework/stolostron-governance-policy-framework-release-2.16-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ presubmits:
branches:
- ^release-2\.16$
- ^release-2\.16-
cluster: build03
cluster: build07
context: ci/prow/test-e2e-grc-framework
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- build/Dockerfile.e2etest
labels:
capability/arm64: arm64
ci-operator.openshift.io/cluster: build07
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-stolostron-governance-policy-framework-release-2.16-test-e2e-grc-framework
Expand Down
4 changes: 3 additions & 1 deletion ...ance-policy-framework/stolostron-governance-policy-framework-release-2.17-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ presubmits:
branches:
- ^release-2\.17$
- ^release-2\.17-
cluster: build03
cluster: build07
context: ci/prow/test-e2e-grc-framework
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- build/Dockerfile.e2etest
labels:
capability/arm64: arm64
ci-operator.openshift.io/cluster: build07
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-stolostron-governance-policy-framework-release-2.17-test-e2e-grc-framework
Expand Down
4 changes: 3 additions & 1 deletion ...nance-policy-framework/stolostron-governance-policy-framework-release-5.0-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,16 @@ presubmits:
branches:
- ^release-5\.0$
- ^release-5\.0-
cluster: build08
cluster: build06
context: ci/prow/test-e2e-grc-framework
decorate: true
decoration_config:
sparse_checkout_files:
- .ci-operator.yaml
- build/Dockerfile.e2etest
labels:
capability/arm64: arm64
ci-operator.openshift.io/cluster: build06
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-stolostron-governance-policy-framework-release-5.0-test-e2e-grc-framework
Expand Down