Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
nodejs-github-bot
added
build
danielleadams
added a commit
to danielleadams/node
that referenced
this pull request
Jun 11, 2022
Notable changes: * crypto: * remove Node.js-specific webcrypto extensions (Filip Skokan) nodejs#43310 * add CFRG curves to Web Crypto API (Filip Skokan) nodejs#42507 * report: * add more heap infos in process report (theanarkh) nodejs#43116 * src: * add --openssl-shared-config option (Daniel Bevenius) nodejs#43124 * add OpenSSL config appname (Daniel Bevenius) nodejs#43124 * add initial shadow realm support (Chengzhong Wu) nodejs#42869 PR-URL: nodejs#43385
danielleadams
force-pushed
the
v18.4.0-proposal
branch
from
8d2ecbc to
b73b76a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Hey, #42623 is blocked because we want to release a few PRs together. I see it listed in the notes here; is it included in this release? See a few others in the same situation: https://github.com/nodejs/node/issues?q=label%3Abackport-blocked-v18.x+sort%3Aupdated-desc+ |
Contributor
|
Is it plausible to pull this #43301 in? 🤔 |
VoltrexKeyva
added
release
tniessen
approved these changes
Jun 12, 2022
Contributor
Author
@GeoffreyBooth yeah, you're correct. The tag filtering was giving me some trouble, and I didn't see to catch all of them. I'll run the diff again. Thanks! |
Refs: #11321 Refs: #17384 PR-URL: #43257 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel and M1 Macs. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43241 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #43261 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #43286 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #43235 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #43298 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Refs: https://github.com/codecov/codecov-action/releases PR-URL: #43297 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Add some initial doc based on discussion with Guy Bedford. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #43255 Reviewed-By: Guy Bedford <[email protected]>
Add missing initialization reported by coverity. With proper usage it looks like it will be initialized but still good to have it initialized to a known state in case that changes or invalide usage. The method used to create object ids newObjectId() starts at 1 so initializing to 0 should be safe and what we get now when compiled in a way that auto initializes (for example debug) Signed-off-by: Michael Dawson <[email protected]> PR-URL: #43254 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #43412 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]>
Event listeners passed to un/subscribe the abort event are mismatched. This removes the wrapper function in `eventTargetAgnosticAddListener()` and directly passes the given listener to the `EventTarget`. IMO, removing the wrapper seems harmless, and the `AbortSignal` is seemingly the only `EventTarget` passed to this function for now. Fixes: #43337 Refs: #33659 Refs: #34997 Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43373 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #43402 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: #43390 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #43346 Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #43405 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #43404 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #43395 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #43375 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: #43014 PR-URL: #43054 Fixes: #43014 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
| The string method | looks up the property | | ----------------------------- | --------------------- | | `String.prototype.match` | `Symbol.match` | | `String.prototype.matchAll` | `Symbol.matchAll` | | `String.prototype.replace` | `Symbol.replace` | | `String.prototype.replaceAll` | `Symbol.replace` | | `String.prototype.search` | `Symbol.search` | | `String.prototype.split` | `Symbol.split` | Functions that lookup the `exec` property on the prototype chain: * `RegExp.prototype[Symbol.match]` * `RegExp.prototype[Symbol.matchAll]` * `RegExp.prototype[Symbol.replace]` * `RegExp.prototype[Symbol.search]` * `RegExp.prototype[Symbol.split]` * `RegExp.prototype.test` `RegExp.prototype[Symbol.replace]` and `RegExp.prototype[Symbol.split]` are still allowed for a lack of a better solution. PR-URL: #43393 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #43391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
danielleadams
added a commit
that referenced
this pull request
Jun 16, 2022
Notable changes: * crypto: * remove Node.js-specific webcrypto extensions (Filip Skokan) #43310 * add CFRG curves to Web Crypto API (Filip Skokan) #42507 * dns: * accept `'IPv4'` and `'IPv6'` for `family` (Antoine du Hamel) #43054 * report: * add more heap infos in process report (theanarkh) #43116 PR-URL: #43385
danielleadams
force-pushed
the
v18.4.0-proposal
branch
from
1ebd250 to
40d7acc
Compare
Notable changes: * crypto: * remove Node.js-specific webcrypto extensions (Filip Skokan) #43310 * add CFRG curves to Web Crypto API (Filip Skokan) #42507 * dns: * accept `'IPv4'` and `'IPv6'` for `family` (Antoine du Hamel) #43054 * report: * add more heap infos in process report (theanarkh) #43116 PR-URL: #43385
danielleadams
force-pushed
the
v18.4.0-proposal
branch
from
40d7acc to
e339e9c
Compare
Collaborator
Member
|
This breaks fastify tests. It's ok as it's related to the interface change. |
Contributor
Author
@mcollina good to know - thanks. |
danielleadams
added a commit
that referenced
this pull request
Jun 16, 2022
Notable changes: * crypto: * remove Node.js-specific webcrypto extensions (Filip Skokan) #43310 * add CFRG curves to Web Crypto API (Filip Skokan) #42507 * dns: * accept `'IPv4'` and `'IPv6'` for `family` (Antoine du Hamel) #43054 * report: * add more heap infos in process report (theanarkh) #43116 PR-URL: #43385
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jun 16, 2022
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jun 16, 2022
This was referenced Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2022-06-16, Version 18.4.0 (Current), @danielleadams
Notable Changes
'IPv4'and'IPv6'forfamily(Antoine du Hamel) #43054Commits
702bfa0b7c] - async_hooks: usekEmptyObject(LiviaMedeiros) #43159f7c4015fd8] - bootstrap: consolidate global properties definition (Chengzhong Wu) #433578d892f5259] - build: add nonpm and nocorepack to vcbuild.bat (Darshan Sen) #432194109ddc005] - child_process: usekEmptyObject(LiviaMedeiros) #431597b5cb14f0c] - cluster: usekEmptyObject(LiviaMedeiros) #431599f1de2c005] - crypto: fix webcrypto import of cfrg raw public keys (Filip Skokan) #434047f02e22998] - crypto: test webcrypto ec raw public key import (Filip Skokan) #434050a075cb548] - crypto: fix webcrypto JWK EC and OKP import crv check (Filip Skokan) #43346df0903c8e8] - crypto: usekEmptyObject(LiviaMedeiros) #431596d0053345e] - (SEMVER-MINOR) crypto: remove Node.js-specific webcrypto extensions (Filip Skokan) #4331028c034d6b5] - (SEMVER-MINOR) crypto: add CFRG curves to Web Crypto API (Filip Skokan) #42507fe7fd85109] - deps: update Corepack to 0.11.2 (Maël Nison) #43402517f17b214] - deps: update undici to 5.5.1 (Node.js GitHub Bot) #43412f4c830fbe4] - deps: upgrade npm to 8.12.1 (npm CLI robot) #433010bb84b09a5] - (SEMVER-MINOR) dns: accept'IPv4'and'IPv6'forfamily(Antoine du Hamel) #43054f91babe494] - doc: packages documentation updates for 12 EOL (Guy Bedford) #43375066f963ec1] - doc: add initial doc on how to update cjs-module-lexer (Michael Dawson) #4325536e5684ae0] - doc: clarify use of deps/icu-small (Michael Dawson) #43287b9634e7ef3] - doc: remove llnode from diag tierlist (Tony Gorez) #432894caeb10e7b] - doc: remove ETW from diag tierlist (Tony Gorez) #4329541955e5ce5] - doc: use serial comma in report docs (Tobias Nießen) #43394e30d4c1cb0] - doc: add fspromises mkdir example (Tierney Cyren) #40843adec5fa929] - doc: add F3n67u to triagers (Feng Yu) #43350cc3505b192] - doc: fix typo in globals.md (Daeyeon Jeong) #43365052c8eaf6a] - doc: use serial comma in webstreams docs (Tobias Nießen) #43353b824a0b7d0] - doc: fix specifier example inesm.md(hiroki osame) #43351d558b3c028] - doc: add undici to glossary (F3n67u) #43327f9ad98f5cb] - doc: change glossary link in pull request guide to node's glossary doc (Feng Yu) #4331802944a6783] - doc: fix typo in util.parseArgs usage example (Michael Ficarra) #43332f2bc6a3f71] - doc: improve description of TZ (Tobias Nießen) #433349335ea6c35] - doc: use serial comma in net docs (Tobias Nießen) #4333505f38c6c3e] - doc: make clear the result of comparison between Symbol.for (Kohei Ueno) #43309c9aed9de9f] - doc: add missing require to stream api doc (Feng Yu) #43237f3188c1c9c] - doc: add CIGTM toglossary.md(Feng Yu) #43316c572d2d115] - doc: use serial comma in pull request doc (Feng Yu) #433198a4e1fa002] - doc: use serial comma in ESM docs (Tobias Nießen) #43322fff0560a66] - doc: promote cdt to tier 3 (Tony Gorez) #432907d0f6da97f] - doc: fix chromium document link in pull-requests.md (rikapo) #432654674b0d2a5] - doc: fix 404 link of BUILDING.md (Feng Yu) #43234ee392c5c0b] - doc: update CHANGELOG_V18.md (Filip Skokan) #432985a3a2a197f] - doc: add src/crypto to CC list for nodejs/crypto (Tobias Nießen) #4328669ce50396c] - doc: use serial comma in console docs (Tobias Nießen) #432570c5092c51c] - events: fix adding abort listener inevents.once(Daeyeon Jeong) #43373fda2105481] - events: usekEmptyObject(LiviaMedeiros) #4315963bf49b143] - fs: usekEmptyObject(LiviaMedeiros) #431599b764531b9] - fs: export constants fromfs/promises(Feng Yu) #43177a4409f85f8] - http: usekEmptyObject(LiviaMedeiros) #431592ffd54105a] - http2: usekEmptyObject(LiviaMedeiros) #43159b468b8fe51] - https: usekEmptyObject(LiviaMedeiros) #43159d2a98dc6cf] - inspector: add missing initialization (Michael Dawson) #432543b2f7eed39] - lib: usekEmptyObjectin various places (LiviaMedeiros) #431594a9511d971] - lib: give names to promisified methods (LiviaMedeiros) #43218b8644606eb] - lib: use null-prototype objects for property descriptors (Antoine du Hamel) #4327064edd6cbc3] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #43399b05cea57ba] - meta: update AUTHORS (Node.js GitHub Bot) #43387a8ecec57e3] - meta: move one or more collaborators to emeritus (meta: move one or more collaborators to emeritus #43183) (Node.js GitHub Bot) #4318360dc36244a] - meta: update AUTHORS (Node.js GitHub Bot) #433129803b82ac7] - net,dns: move hasObserver out of perf function (theanarkh) #43217112518fb1d] - perf_hooks: fix function wrapped bytimerifyto work correctly (Kohei Ueno) #43330a3310d13bf] - perf_hooks: usekEmptyObject(LiviaMedeiros) #431597e8a00a26d] - readline: fix question stack overflow (Eugene Chapko) #433205e98cacf77] - readline: usekEmptyObject(LiviaMedeiros) #4315966d956ca49] - repl: make autocomplete case-insensitive (Sergey Petushkov) #41632201f3d7f56] - (SEMVER-MINOR) report: add more heap infos in process report (theanarkh) #43116a0568409b6] - src: fix json utils escapes for U+000B (Chengzhong Wu) #43206931ecfa033] - src: fix memory leaks and refactorByteSource(Tobias Nießen) #432025e65c1f3da] - src: convey potential exceptions during StreamPipe construction (Darshan Sen) #43240b200a5ff67] - stream: usekEmptyObject(LiviaMedeiros) #431591cc1a57cdb] - test: remove unused argument in test-util-inspect.js (Colin Ihrig) #4339542c2115a82] - test: mark test_buffer/test_finalizer flaky (Michael Dawson) #4341471802c32d0] - test: fix address in use error (Caleb Everett) #43199e1b8c85a7a] - test: add test for short-option followed by its value (Kohei Ueno) #43358f8d26c6011] - test: fixcommon.mustNotCallerror message (Antoine du Hamel) #4291718fffe6108] - test: convert then to async/await (Meek Simbule) #43292acd96d80eb] - test: addBigInts tocommon.getArrayBufferViews()(LiviaMedeiros) #43235e576a7fa50] - test_runner: usekEmptyObject(LiviaMedeiros) #43159fecad7a3a5] - timers: usekEmptyObject(LiviaMedeiros) #43159e31baca76a] - tls: usekEmptyObject(LiviaMedeiros) #431597f8f61a749] - tls: fix performance regression inconvertALPNProtocols()(LiviaMedeiros) #43250ac9599a718] - tools: report unsafe string and regex primordials as lint errors (Antoine du Hamel) #43393b69d874592] - tools: fixcreate-or-update-pull-request-actionhash on GHA (Antoine du Hamel) #43378cf8a115983] - tools: addavoid-prototype-pollutionlint rule (Antoine du Hamel) #433088c0fe1e184] - tools: fix find-inactive actions (LiviaMedeiros) #433777f45d69f83] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #43313d5d0f01c5a] - tools: update eslint to 8.17.0 (Node.js GitHub Bot) #43314f598fe1585] - tools: use hashes instead of tags for external actions (tools: use hashes instead of tags for external actions #43284) (Antoine du Hamel) #4328410f79947d9] - tools: updatecodecov/codecov-actionversion (Antoine du Hamel) #43297f93848fa50] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #43261b3d7dc1de8] - tools: update clang-format 1.7.0 to 1.8.0 (Darshan Sen) #43241812140c65a] - tools,doc: add guards against prototype pollution when creating proxies (Antoine du Hamel) #4339156b8cc5cef] - util: freezekEnumerableProperty(LiviaMedeiros) #43390b187d55b6d] - util: addkEmptyObjectto internal/util (LiviaMedeiros) #43159024b396275] - vm: usekEmptyObject(LiviaMedeiros) #431597fc432fa35] - wasi: usekEmptyObject(LiviaMedeiros) #4315944b65d0ca7] - worker: usekEmptyObject(LiviaMedeiros) #43159