Revert the change of network interfaces family from string to integer by aduh95 · Pull Request #43054 · nodejs/node

aduh95 · 2022-05-11T07:54:22Z

This reverts commits 68fb0bf, 4ad342a, and 3a26db9.

nodejs-github-bot · 2022-05-11T07:54:26Z

Review requested:

@nodejs/net

targos · 2022-05-11T09:28:42Z

IMO the revert doesn't make sense if it is semver-major, because everyone will have to adapt to the change for v18 (which is going to be LTS).

mcollina

lgtm

mcollina

lgtm

mcollina · 2022-05-11T12:10:51Z

+1 to land it on Node v18.

mcollina · 2022-05-11T12:15:12Z

~~@nodejs/tsc at Today meeting we did not have quorum to LGTM as a non-semver-major change. Does anybody from the TSC objects to this?~~

We actually had quorum at the end of the meeting, we approve landing this as semver-minor.

lib/dns.js

RaisinTen · 2022-05-11T13:07:54Z

Is it okay if we remove this from the tsc-agenda now, since everyone in the meeting was +1 with reverting?

Trott

Rubber stamp

nodejs-github-bot · 2022-06-06T23:09:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44397/

nodejs-github-bot · 2022-06-07T22:06:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44401/

nodejs-github-bot · 2022-06-08T16:03:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44409/

mhdawson · 2022-06-15T21:56:55Z

We discussed in the TSC meeting and there were no objections to this landing. Doing that now.

Refs: #43014 PR-URL: #43054 Fixes: #43014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

mhdawson · 2022-06-15T22:04:33Z

Landed as 70b516e

Refs: #43014 PR-URL: #43054 Fixes: #43014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Notable changes: * crypto: * remove Node.js-specific webcrypto extensions (Filip Skokan) #43310 * add CFRG curves to Web Crypto API (Filip Skokan) #42507 * dns: * accept `'IPv4'` and `'IPv6'` for `family` (Antoine du Hamel) #43054 * report: * add more heap infos in process report (theanarkh) #43116 PR-URL: #43385

Aligns Deno's `server.address()` with Node.js v18.4.0+ behavior by returning the `family` property as a string ("IPv4" or "IPv6") rather than a number. Node.js briefly changed `family` from string to number in v18.0.0 (nodejs/node#41431), but reverted in v18.4.0 (nodejs/node#43054) due to ecosystem breakage (nodejs/node#43014). This fix ensures compatibility with npm packages that rely on the string format, which has been the stable API since Node.js v18.4.0. Refs: - nodejs/node#43054 - nodejs/node@70b516e 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Aligns Deno's Node.js compatibility layer with Node.js v18.4.0+ behavior by returning the `family` property as a string ("IPv4" or "IPv6") rather than a number in `server.address()` and socket address methods. Node.js briefly changed `family` from string to number in v18.0.0 (nodejs/node#41431), but reverted in v18.4.0 (nodejs/node#43054) due to ecosystem breakage (nodejs/node#43014). Changes: - `http.Server.address()`, `https.Server.address()`, `http2.Server.address()` now include `family` property as string - `net.Server.address()` returns string `family` via tcp_wrap.ts - `socket.remoteFamily` returns string instead of number - `dns.lookup()` accepts both numeric (0, 4, 6) and string ("IPv4", "IPv6") family values, matching Node.js behavior Family value derivation follows Node.js C++ implementation: - isIP() === 4 → "IPv4" - isIP() === 6 → "IPv6" - isIP() === 0 → undefined (defensive, matches Node.js behavior for non-IP addresses, though not practically reachable via TCP server APIs) Refs: - nodejs/node#43054 - nodejs/node@70b516e 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

## Summary Aligns Deno's Node.js compatibility layer (`node:net`, `node:http`, `node:https`, `node:http2`, `node:dns`) with Node.js v18.4.0+ behavior by returning the `family` property as a string (`"IPv4"` or `"IPv6"`) rather than a number in `server.address()` and socket address methods. Node.js briefly changed `family` from string to number in v18.0.0 (nodejs/node#41431), but reverted in v18.4.0 (nodejs/node#43054) due to ecosystem breakage (nodejs/node#43014). This fix ensures compatibility with npm packages that rely on the string format, which has been the stable API since Node.js v18.4.0. ## Changes - Modified `ext/node/polyfills/http.ts` to add `family` property to `address()` return - Modified `ext/node/polyfills/internal_binding/tcp_wrap.ts` to return string `family` instead of number in `getsockname()`, `getpeername()`, and `#connect()` - Modified `ext/node/polyfills/net.ts` to fix `socket.remoteFamily` getter (no longer needs conversion since `family` is now a string) - Modified `ext/node/polyfills/dns.ts` and `ext/node/polyfills/internal/dns/promises.ts` to accept string family values (`"IPv4"`, `"IPv6"`) in `lookup()`, matching [Node.js behavior](https://nodejs.org/api/dns.html#dnslookuphostname-options-callback) - Added tests in `tests/unit_node/http_test.ts`, `tests/unit_node/http2_test.ts`, `tests/unit_node/https_test.ts`, `tests/unit_node/dns_test.ts`, and `tests/unit_node/net_test.ts` ## Node.js Compatibility Note For non-IP addresses (when `isIP()` returns 0), the `family` property is `undefined`. This matches Node.js C++ behavior in [`AddressToJS`](https://github.com/nodejs/node/blob/main/src/tcp_wrap.cc) where family is only set for `AF_INET` (`"IPv4"`) and `AF_INET6` (`"IPv6"`), and left undefined otherwise. ## Refs - nodejs/node#43054 - nodejs/node@70b516e  --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Daniel Rahmanto <daniel.rahmanto@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 11, 2022

aduh95 added semver-major PRs that contain breaking changes and should be released in the next major version. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels May 11, 2022

mcollina approved these changes May 11, 2022

View reviewed changes

mcollina added semver-major PRs that contain breaking changes and should be released in the next major version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels May 11, 2022

targos added the backport-requested-v18.x label May 11, 2022

mcollina added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v12.x and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels May 11, 2022

RaisinTen added the notable-change PRs with changes that should be highlighted in changelogs. label May 11, 2022

RaisinTen approved these changes May 11, 2022

View reviewed changes

lib/dns.js Outdated Show resolved Hide resolved

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed backport-requested-v18.x labels May 11, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2022

This comment was marked as outdated.

Sign in to view

BethGriggs approved these changes May 11, 2022

View reviewed changes

Trott approved these changes May 11, 2022

View reviewed changes

github-actions bot mentioned this pull request Jun 13, 2022

CI Reliability 2022-06-13 nodejs/reliability#299

Open

15 tasks

mhdawson mentioned this pull request Jun 15, 2022

Node.js Technical Steering Committee (TSC) Meeting 2022-06-15 nodejs/TSC#1242

Closed

mhdawson closed this Jun 15, 2022

aduh95 mentioned this pull request Jun 15, 2022

v18.4.0 proposal #43385

Merged

chitowncrispy mentioned this pull request Jul 23, 2022

🐛 BUG: unable to find network to expose when exposing to network with Node 18.1+ withastro/astro#3598

Closed

1 task

timacdonald mentioned this pull request Jul 25, 2022

HRM hot file use IPv6 while vite devserver running on IPv4 laravel/vite-plugin#103

Closed

AdamMajer mentioned this pull request Jul 28, 2022

test: Error: getaddrinfo ENOTFOUND localhost #44003

Closed

aduh95 deleted the revert-net-family-integer branch March 29, 2023 16:00

aduh95 mentioned this pull request Mar 29, 2023

doc: fix outdated documentation for family property #42789

Merged

sapphi-red mentioned this pull request Aug 10, 2023

feat!: bump minimum node version to 18 vitejs/vite#14030

Merged

9 tasks

aduh95 mentioned this pull request Sep 16, 2024

doc: remove outdated sentence #54963

Closed

nrako mentioned this pull request Nov 30, 2025

fix(node/net): return string family in server.address() denoland/deno#31465

Merged

Uh oh!

Conversation

aduh95 commented May 11, 2022

Uh oh!

nodejs-github-bot commented May 11, 2022

Uh oh!

targos commented May 11, 2022

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented May 11, 2022

Uh oh!

mcollina commented May 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

RaisinTen commented May 11, 2022

Uh oh!

This comment was marked as outdated.

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 6, 2022

Uh oh!

nodejs-github-bot commented Jun 7, 2022

Uh oh!

nodejs-github-bot commented Jun 8, 2022

Uh oh!

mhdawson commented Jun 15, 2022

Uh oh!

mhdawson commented Jun 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

mcollina commented May 11, 2022 •

edited

Loading