tools: update lint-md-dependencies to rollup@2.75.3#43261
Closed
nodejs-github-bot wants to merge 0 commit intomasterfrom
Closed
tools: update lint-md-dependencies to rollup@2.75.3#43261nodejs-github-bot wants to merge 0 commit intomasterfrom
nodejs-github-bot wants to merge 0 commit intomasterfrom
Conversation
Trott
approved these changes
May 31, 2022
Trott
added
fast-track
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
Collaborator
Author
VoltrexKeyva
approved these changes
May 31, 2022
RaisinTen
approved these changes
May 31, 2022
tniessen
approved these changes
May 31, 2022
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
This seems like a patch-only update with no real changes? This feels like a lot of noise for that.
lpinca
approved these changes
May 31, 2022
17 tasks
Member
|
Not sure why neither the GitHub widget nor the nodejs-github-bot are picking up the fact that there's been more recent Jenkins runs but here are two ones that are going right now. |
Member
You're not wrong, but still, for me, most of the noise is due to CI unreliability (and, uh, perhaps my own penchant for leaving lots of comments....). Otherwise, this would have been landed via fast-track far earlier. I don't know if it was quite this small, but we had an issue where an update like this broke things on one of the containered builds in Jenkins, so I'm personally OK with small updates like this. Makes it easy to see when something broke instead of having to dig for the needle in the haystack of tons of dependencies being updated at once. |
Member
|
This one is green. Landing. |
Member
|
Landed in 29c64ce |
Trott
pushed a commit
that referenced
this pull request
Jun 1, 2022
PR-URL: #43261 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
force-pushed
the
actions/tools-update-lint-md-dependencies
branch
from
dd7b61a to
5418dd0
Compare
Trott
force-pushed
the
actions/tools-update-lint-md-dependencies
branch
from
5418dd0 to
29c64ce
Compare
This was referenced Jun 2, 2022
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 6, 2022
PR-URL: nodejs#43261 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
PR-URL: #43261 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43261 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43261 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43261 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43261 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of lint-md-dependencies to rollup@2.75.3.