JSON config > + original_route_type_id & route_long_name route def

[mmathieum]

No description provided.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces the originalRouteTypeId field to AgencyConfig and enhances route configuration by allowing route short names and colors to be resolved using route long names. It also renames RouteIdToRouteShortNameConfig to RouteDefToShortNameConfig and deprecates the old configuration property. Feedback was provided to decouple the new routeToRouteShortNameConfigs property from its deprecated counterpart by avoiding using it as a default value.

[gemini-code-assist]

Code Review

This pull request enhances the GTFS parsing configuration by introducing an original_route_type_id in AgencyConfig and expanding route matching capabilities in RouteConfig. Route short names and colors can now be resolved using route long names in addition to IDs and short names. The review feedback suggests making the routeId optional in RouteDefToShortNameConfig to allow matching exclusively by long name and identifies a redundant short name check in getRouteShortNameForRoute since that method is specifically intended for cases where the short name is missing.

[Copilot]

Pull request overview

Adds new JSON-configurable route metadata matching options, enabling configuration-driven handling of original route types and route short-name/color selection based on route_long_name in addition to route_id.

Changes:

• Add original_route_type_id to GTFS agency config and use it in getOriginalAgencyRouteType().
• Extend route short-name configuration to match by route_id or route_long_name (with backward-compatible config key support).
• Extend route color selection to optionally match by route_long_name.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/main/java/org/mtransit/parser/DefaultAgencyTools.java	Uses agency original_route_type_id when available; switches missing short-name lookup to route-level matching helper.
src/main/java/org/mtransit/parser/config/gtfs/data/RouteConfig.kt	Introduces route-def-based short-name mapping (by route_id or route_long_name) and adds route_long_name matching to route color selection.
src/main/java/org/mtransit/parser/config/gtfs/data/AgencyConfig.kt	Adds original_route_type_id with a default value based on target_route_type_id.

Comments suppressed due to low confidence (1)

src/main/java/org/mtransit/parser/DefaultAgencyTools.java:588

• The new fallback logic for missing route short names now depends on RouteConfig.getRouteShortNameForRoute() which supports matching by route_long_name. There don’t appear to be existing unit tests covering provideMissingRouteShortName behavior, so regressions (e.g., precedence of route_id vs route_long_name, or handling of missing configs) may go unnoticed. Consider adding targeted tests around this new mapping behavior.

	public String provideMissingRouteShortName(@NotNull GRoute gRoute) {
		//noinspection DiscouragedApi
		final String routeShortNameFromRouteId = Configs.getRouteConfig().getRouteShortNameForRoute(gRoute);
		if (routeShortNameFromRouteId != null) {
			return routeShortNameFromRouteId;
		}
		if (Configs.getRouteConfig().getUseRouteLongNameForMissingRouteShortName()) {
			return gRoute.getRouteLongNameOrDefault();
		}
		throw new MTLog.Fatal("No default route short name for %s!", gRoute.toStringPlus());

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces enhancements to route configuration handling, including the addition of original route type IDs, support for route long names in short name lookups, and improved route color resolution. I have suggested adding an init block to the RouteDefToShortNameConfig data class to ensure data integrity by requiring either a route ID or route long name, and recommended correcting a typo in a variable name for better readability.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.