String cleaner > tweak short trip head-sign & stop name...

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the string cleaning utility by introducing more nuanced control over string shortening for trip headsigns and stop names, ensuring that shorter strings are not unnecessarily truncated. It also enhances the robustness of several regular expression patterns used for cleaning, leading to more accurate and consistent text processing. The changes aim to improve the readability and conciseness of displayed transit information.

Highlights

• Conditional String Shortening: Implemented length-based conditions for applying 'short' cleaning to trip headsigns and stop names, using new constants TRIP_HEADSIGN_SHORT_MAX_LENGTH (13) and STOP_NAME_SHORT_MAX_LENGTH (17).
• Regex Pattern Refinements: Adjusted regular expression patterns in CleanUtilsExt.kt (makeALL_ST_REGEX, makeALL_CHARS_REGEX, makeALL_FACE_A_REGEX) to improve matching of string prefixes and delimiters, particularly concerning whitespace and slashes.
• Consistent Case Fixing: Modified cleanString to always apply CleanUtils.fixMcXCase for English strings, removing its previous dependency on the short cleaning flag.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces maximum length constants for trip headsigns and stop names, using them to conditionally apply shortening logic. It also adjusts the application of fixMcXCase for English strings to always apply, not just when shortening. Additionally, it modifies several regex patterns in CleanUtilsExt.kt. A potential regression was identified in the makeALL_FACE_A_REGEX change, as it might prevent matching phrases like "face à" when they appear after a word.