JSON config > + direction_[finder|splitter]_disabled_until

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the configuration system by introducing date-based control for the direction splitter and finder features. It allows specific routes to have these features temporarily disabled until a configured date, providing greater flexibility in managing feature rollouts or temporary adjustments without requiring code changes.

Highlights

• New Configuration Options: Introduced direction_splitter_disabled_until and direction_finder_disabled_until fields in the RouteConfig to allow temporary disabling of these features until a specified date.
• Date-Based Feature Toggling: Modified DefaultAgencyTools to utilize the new date-based configuration, enabling dynamic control over the direction splitter and finder based on the current date.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances the directionSplitter and directionFinder features by introducing date-based and route-specific control. Previously, these features were controlled by simple boolean flags, but now they can be disabled until a specified date for particular routes. The DefaultAgencyTools class has been updated to utilize this new, more granular logic. A minor formatting issue was noted in the new function signatures, where a space is missing after a comma in the parameter lists, which should be addressed for better readability and adherence to Kotlin style guidelines.