fix(transform): handle Set and Array for conditions in esm sync loader#41316
Closed
SebTardif wants to merge 1 commit into
Closed
fix(transform): handle Set and Array for conditions in esm sync loader#41316SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
Node registerHooks can pass \`conditions\` as a Set (not Array) in some require-initiated sync paths on Node 22.15-22.16. The check added in microsoft#41138 used optional chaining \`.includes\` which does not exist on Set, causing "conditions?.includes is not a function" during test loading (see microsoft#41311). Use a safe \`has\` / \`includes\` probe. Widen the type annotation. Added regression test for the ESM resolve path. Fixes microsoft#41311 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Collaborator
|
Closing is favor of #41319. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node registerHooks can pass `conditions` as a Set (not Array) in some
require-initiated sync paths on Node 22.15-22.16. The check added in #41138
used optional chaining `.includes` which does not exist on Set, causing
"conditions?.includes is not a function" during test loading.
Use a safe `has` / `includes` probe. Widen the type annotation.
Added regression test for the ESM resolve path.
Fixes #41311