fix(test): pass file:// URL to the ESM resolver in the sync loader#41138
Merged
Conversation
Adds a regression test for ESM projects importing a real relative .js
file, which the resolve hook turns into an absolute path. On Windows the
default ESM resolver rejects it ("Received protocol 'c:'").
The Windows ttest bots ran Node 20, which does not use the synchronous
module customization hooks, so this path was never exercised. Default
all ttest bots to Node 22 and keep Node 20 coverage on ubuntu only.
Refs: microsoft#41121
This comment has been minimized.
This comment has been minimized.
The synchronous module customization hooks serve both require() and
import. When resolveHook rewrites a specifier, require()'s resolver
wants an absolute path while the ESM resolver wants a file:// URL and,
on Windows, mistakes an absolute path's drive letter for a URL scheme
("Received protocol 'c:'"). Pick the form using the `import` condition.
Remove the temporary regression test; the bumped Windows + Node 22 ttest
bots already cover this path.
Fixes: microsoft#41121
dgozman
changed the title
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"7230 passed, 1103 skipped Merge workflow run. |
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Jun 4, 2026
Contributor
Test results for "tests 1"1 flaky39544 passed, 771 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require()andimport:require()'s resolver wants an absolute path, while the ESM resolver wants afile://URL and, on Windows, mistakes an absolute path's drive letter for a URL scheme (Received protocol 'c:'). Pick the form using theimportcondition.Fixes #41121