Skip to content

fix(loader): support other node versions#41319

Merged
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:fix-esm-loader-sync
Jun 16, 2026
Merged

fix(loader): support other node versions#41319
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:fix-esm-loader-sync

Conversation

@dgozman

@dgozman dgozman commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

In some versions of Node like 22.15 or 23.11, context.conditions is a Set rather than an Array.

Fixes #41311.

In some versions of Node like 22.15 or 23.11,
`context.conditions` is a Set rather than an Array.
@dgozman dgozman requested a review from Skn0tt June 16, 2026 08:36
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chromium] › mcp/screenshot.spec.ts:371 › browser_take_screenshot (viewport without snapshot) @mcp-windows-latest-chromium

7340 passed, 1122 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/video.spec.ts:680 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/workers.spec.ts:191 › should attribute network activity for worker inside iframe to the iframe `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`

39579 passed, 743 skipped


Merge workflow run.

@dgozman dgozman merged commit 33458b7 into microsoft:main Jun 16, 2026
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [Regression]: Sync loader throws "context.conditions?.includes is not a function" on Node 22.15

2 participants