Add data streaming service with WifiDataStreamUpload API#174
Merged
Conversation
…treaming-service Add placeholder for data streaming service
…load-api Implement WifiDataStreamUpload API
…ent-unit-test Add unit test for WifiDataStreamUpload with multiple parallel clients
Merge develop into feature/dataStreaming
abeltrano
reviewed
Feb 27, 2024
abeltrano
requested changes
Feb 27, 2024
…ew-comments Address review comments for initial API
abeltrano
requested changes
Feb 27, 2024
abeltrano
reviewed
Feb 27, 2024
…ew-comments-2 Address review comments
abeltrano
reviewed
Feb 27, 2024
abeltrano
reviewed
Feb 27, 2024
abeltrano
approved these changes
Feb 27, 2024
…ew-comments-3 Address review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
This PR adds a new gRPC service for data streaming to NetRemote, along with one API method for client-to-server streaming.
Fix #77.
Technical Details
NetRemoteDataStreamingServicegRPC service and run fromNetRemoteServer.WifiDataStreamUploadAPI toNetRemoteDataStreamingService.proto.WifiDataStreamUploadAPI inNetRemoteDataStreamingService, factoring out the reactor class intoNetRemoteDataStreamingReactors.Test Results
All tests pass.
Reviewer Focus
None.
Future Work
None.
Checklist
allcompiles cleanly.