Skip to content

Address review comments for initial API#177

Merged
corbin-phipps merged 18 commits into
feature/dataStreamingfrom
user/corbinphipps/address-review-comments
Feb 27, 2024
Merged

Address review comments for initial API#177
corbin-phipps merged 18 commits into
feature/dataStreamingfrom
user/corbinphipps/address-review-comments

Conversation

@corbin-phipps
Copy link
Copy Markdown
Contributor

@corbin-phipps corbin-phipps commented Feb 27, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

Addresses review comments before feature/dataStreaming merges into develop.

Technical Details

  • Improve unit test code.
  • Move test client reactor into separate files.
  • Move data streaming RPC and data types out of Wi-Fi and into own protocol.

Test Results

All tests pass.

Reviewer Focus

None.

Future Work

  • Avoid manual memory management for ServerReadReactor.
  • Add tracing (NetRemoteDataStreamApiTrace).

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

abeltrano and others added 18 commits February 26, 2024 04:20
@abeltrano
Expand AccessPointOperationStatus to include ap id and op name.
07ccf40
@abeltrano
Add helper to log AccessPointOperationStatus on exit.
4f797cd
@abeltrano
Remove old fields and ctor.
799566c
@abeltrano
Use AccessPointOperationStatusLogOnExit for consistent logging.
1b00b23
@abeltrano
Updates to include source_location info with DEBUG builds.
a7e1e60
@abeltrano
Add tests.
18c6226
@abeltrano
Fix function name parsing.
9d3b600
@abeltrano
Expand MakeSucceeded arguments.
03d816e
@abeltrano
Consistent log details.
36ac2cf
@abeltrano
Use default-arg for operation names where possible.
deb2df1
@abeltrano
Merge pull request #176 from microsoft/opstatusif
c9aac1d 
Log access point operations consistently
@corbin-phipps
Merge branch 'develop' into user/corbinphipps/address-review-comments
1a762c9
@corbin-phipps
Move dataStreamWriter into lambda capture
77d754a
@corbin-phipps
De duplicate constant
12fb974
@corbin-phipps
Better class member names; use wait_for
73656bb
@corbin-phipps
Add stream tag
263cf2d
@corbin-phipps
Move client reactor to separate class with comments
0b4df31
@corbin-phipps
Move data streaming stuff out of Wi-Fi and into own protocol
8ac8d9e
@corbin-phipps corbin-phipps requested a review from a team as a code owner February 27, 2024 19:16
@corbin-phipps corbin-phipps merged commit 1fb4563 into feature/dataStreaming Feb 27, 2024
@corbin-phipps corbin-phipps deleted the user/corbinphipps/address-review-comments branch February 27, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corbin-phipps @abeltrano