Skip to content

Add placeholder for data streaming service#167

Merged
corbin-phipps merged 3 commits into
feature/dataStreamingfrom
user/corbinphipps/setup-data-streaming-service
Feb 23, 2024
Merged

Add placeholder for data streaming service#167
corbin-phipps merged 3 commits into
feature/dataStreamingfrom
user/corbinphipps/setup-data-streaming-service

Conversation

@corbin-phipps
Copy link
Copy Markdown
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

This PR adds a placeholder for the new data streaming service in NetRemote.

Technical Details

  • Added NetRemoteDataStreamingService.proto file to define the NetRemoteDataStreaming service.
  • Added placeholder header/source files for the implementation of NetRemoteDataStreaming::CallbackService.

Test Results

Builds successfully via CMake Install.

Reviewer Focus

Naming and overall structure.

Future Work

Actual implementation of the service.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@corbin-phipps corbin-phipps requested a review from a team as a code owner February 23, 2024 22:28
@corbin-phipps corbin-phipps merged commit d0a34d2 into feature/dataStreaming Feb 23, 2024
@corbin-phipps corbin-phipps deleted the user/corbinphipps/setup-data-streaming-service branch February 23, 2024 22:35
@abeltrano abeltrano requested a review from a team February 23, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants