feat: update pfrich branch with respect to main

[c-dilks]

Briefly, what does this PR introduce?

Merging pfrich into main is not straightforward and risks breaking dependent code. Therefore, let's first merge main into pfrich, and make sure all important patches are applied to all new files:

• backmerge main and resolve conflicts
• respect build: make ROOT dictionary generation optional #32
• respect fix: File not found with <angled> include; use "quotes" instead #29
• bump version number, respecting chore: add version number for cmake config #13

[c-dilks]

@alexander-kiselev this pfrich-update branch is a "prototype" of the merging of your pfrich branch with main.

Could you please do a "smoke test" and make sure your pfRICH usage still basically works on this pfrich-update branch? Check recent pull requests for more details of what has changed on main.

[alexander-kiselev]

Chris, I will look into this, but cannot promise I do it quickly. What is my deadline? Cheers, Alexander.

…

________________________________ From: Christopher Dilks ***@***.***> Sent: Sunday, May 7, 2023 3:22 PM To: eic/irt ***@***.***> Cc: Kiselev, Alexander ***@***.***>; Mention ***@***.***> Subject: Re: [eic/irt] feat: update `pfrich` branch with respect to `main` (PR #35) @alexander-kiselev<https://github.com/alexander-kiselev> this pfrich-update branch is a "prototype" of the merging of your pfrich branch with main. Could you please do a "smoke test" and make sure your pfRICH usage still basically works on this pfrich-update branch? Check recent pull requests<https://github.com/eic/irt/pulls?q=is%3Apr+is%3Aclosed> for more details of what has changed on main. — Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANV7FINPOBLUJWTYZU6QTK3XE7Y6PANCNFSM6AAAAAAXYUMPGU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[c-dilks]

No deadline, I'm also going to try to do some testing with it in EICrecon within the next couple of weeks. I just wanted to make sure recent CMake build changes won't mess up your usage.

[kkauder]

@alexander-kiselev This comprises only #ifdef guards and cmake generalizations. I checked that it builds on both my mac and in the EicRoot container.
The simple example in pfrich

root -l './examples/pfrich.C("examples/pfrich.root")'

gives a warning "You should update the version to ClassDef(CherenkovPhotonDetector,7)." but so does the pfrich branch.
The compiled pfrich code works fine. I think it's safe to merge but maybe you want to double-check.

[kkauder]

@alexander-kiselev Could you check and approve when you have a few minutes?

[alexander-kiselev]

Hi Kolja, I must be blind and / or dumb today. What is it about? I do not see any issue with any order in this class. Can you come over show me? Cheers, Alexander.

…

________________________________ From: kkauder ***@***.***> Sent: Monday, January 22, 2024 1:09 PM To: eic/irt ***@***.***> Cc: Kiselev, Alexander ***@***.***>; Mention ***@***.***> Subject: Re: [eic/irt] feat: update `pfrich` branch with respect to `main` (PR #35) @alexander-kiselev<https://github.com/alexander-kiselev> Could you check and approve when you have a few minutes? — Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANV7FINNSH4WA2FJI5BRZVLYP2TO5AVCNFSM6AAAAAAXYUMPGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGU2DCNBYGU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[kkauder]

These are changes to the pfrich branch that don't do anything to the logic, just clean up with #ifdef's and so on for better integration with the epic stack.

[alexander-kiselev]

Hi Kolja, I refer to this one, in particular: af346a3 Cheers, Alexander.

…

________________________________ From: kkauder ***@***.***> Sent: Thursday, January 25, 2024 12:22 PM To: eic/irt ***@***.***> Cc: Kiselev, Alexander ***@***.***>; Mention ***@***.***> Subject: Re: [eic/irt] feat: update `pfrich` branch with respect to `main` (PR #35) These are changes to the pfrich branch that don't do anything to the logic, just clean up with #ifdef's and so on for better integration with the epic stack. — Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANV7FIODGDNVZC4TE2YBJBDYQKIGDAVCNFSM6AAAAAAXYUMPGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGY3DCMRXGQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[kkauder]

C++ loves to throw warnings if members aren't initialized in the exact order listed in the class, that's all.

[alexander-kiselev]

I know. Just do not understand where from this problem come here, see the respective code in the main branch: https://github.com/eic/irt/blob/main/include/CherenkovRadiator.h .

…

________________________________ From: kkauder ***@***.***> Sent: Thursday, January 25, 2024 2:01 PM To: eic/irt ***@***.***> Cc: Kiselev, Alexander ***@***.***>; Mention ***@***.***> Subject: Re: [eic/irt] feat: update `pfrich` branch with respect to `main` (PR #35) C++ loves to throw warnings if members aren't initialized in the exact order listed in the class, that's all. — Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANV7FIIYWHKRBMT5KUH4NW3YQKT2LAVCNFSM6AAAAAAXYUMPGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQHAYTAMBTGY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[kkauder]

Remember, this isn't a PR into main but into pfrich. In that branch, you deleted m_ID and Chris restored it (not sure what he needs it for), but in some other place.

[alexander-kiselev]

OK, then I guess I don't care?

…

________________________________ From: kkauder ***@***.***> Sent: Thursday, January 25, 2024 3:09 PM To: eic/irt ***@***.***> Cc: Kiselev, Alexander ***@***.***>; Mention ***@***.***> Subject: Re: [eic/irt] feat: update `pfrich` branch with respect to `main` (PR #35) Remember, this isn't a PR into main but into pfrich. In that branch, you deleted m_ID and Chris restored it (not sure what he needs it for), but in some other place. — Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANV7FIMULHZ5BY2TVGJ7XL3YQK3YBAVCNFSM6AAAAAAXYUMPGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQHEYTGNJSGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[kkauder]

Reviewing, yes, that was my takeaway. I don't see a need for that m_ID, so we can accept it or not, but it didn't move the needle for significance for me. You feel strongly one way or the other, let's do that. @c-dilks , can you add to the need for
this member?

[c-dilks]

Reviewing, yes, that was my takeaway. I don't see a need for that m_ID, so we can accept it or not, but it didn't move the needle for significance for me. You feel strongly one way or the other, let's do that. @c-dilks , can you add to the need for this member?

At least in EICrecon, the primary irt consumer in the spack builds, it appears in 2 places:

• https://github.com/eic/EICrecon/blob/1a26545236361762642a33470c84d0f486a5c40e/src/algorithms/pid/IrtCherenkovParticleID.cc#L93
• https://github.com/eic/EICrecon/blob/1a26545236361762642a33470c84d0f486a5c40e/src/algorithms/pid/IrtCherenkovParticleID.cc#L325

It seems this is only used for log printouts, so it may be safe to remove.