Skip to content

build: make ROOT dictionary generation optional#32

Merged
c-dilks merged 10 commits into
mainfrom
dict-module
Apr 1, 2023
Merged

build: make ROOT dictionary generation optional#32
c-dilks merged 10 commits into
mainfrom
dict-module

Conversation

@c-dilks

@c-dilks c-dilks commented Mar 25, 2023

Copy link
Copy Markdown
Member

Briefly, what does this PR introduce?

Attempts to debug dictionary generation in spack.

Things to test:

  • spack build
  • EICrecon main CI
  • ROOT I/O and usage in Juggler
  • Usage in EICrecon on dev branch irt-algo

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

no

@c-dilks c-dilks changed the title fix: add MODULE to dictionary generator build: make ROOT dictionary generation optional Mar 28, 2023
@c-dilks c-dilks marked this pull request as ready for review April 1, 2023 16:25
@c-dilks c-dilks merged commit 17040c1 into main Apr 1, 2023
@c-dilks c-dilks deleted the dict-module branch April 1, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant