Skip to content

fix: File not found with <angled> include; use "quotes" instead#29

Merged
c-dilks merged 1 commit into
mainfrom
fix-inclusions
Mar 14, 2023
Merged

fix: File not found with <angled> include; use "quotes" instead#29
c-dilks merged 1 commit into
mainfrom
fix-inclusions

Conversation

@c-dilks

@c-dilks c-dilks commented Mar 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Briefly, what does this PR introduce?

Fix #28

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

no

@c-dilks c-dilks mentioned this pull request Mar 8, 2023
Closed
@c-dilks

c-dilks commented Mar 10, 2023

Copy link
Copy Markdown
Member Author

These changes seem to be working fine with EICrecon.

@alexander-kiselev

alexander-kiselev commented Mar 10, 2023 via email

Copy link
Copy Markdown
Collaborator

@c-dilks

c-dilks commented Mar 10, 2023

Copy link
Copy Markdown
Member Author

Chris, are you trying to merge 'pfrich' branch into main? Cheers, Alexander.

Not yet, unless you are ready.

I tagged you in this PR because it changes all the #include <some_IRT_header.h> to #include "some_IRT_header.h"; are you okay with this particular change? It is independent of your pfrich branch.

There are some other changes on main, all of which are for integration into eic-shell (e.g., cmake packaging); they shouldn't conflict with your pfrich branch, and if you want, I can update your pfrich branch to include those changes. But since we are nearing the review, it's probably better I don't try to "fix" what isn't broken :)

@c-dilks

c-dilks commented Mar 10, 2023

Copy link
Copy Markdown
Member Author

P.S. this change of #includes was requested by @DraTeots (Dmitry Romanov).

@c-dilks

c-dilks commented Mar 14, 2023

Copy link
Copy Markdown
Member Author

Merging without review, because we need to keep moving forward and tag a new release; this works fine in EICrecon, but has not been tested in (deprecated) juggler. We can revert this if we ever need to.

@c-dilks c-dilks merged commit 7170da2 into main Mar 14, 2023
@c-dilks c-dilks deleted the fix-inclusions branch March 14, 2023 16:12
@c-dilks c-dilks mentioned this pull request Mar 14, 2023
Merged
wdconinc pushed a commit to eic/eic-spack that referenced this pull request Mar 14, 2023
@c-dilks
irt: new version 1.0.4 (#414)
ae13faa 
### Briefly, what does this PR introduce?
@wdconinc I realize you probably have a bot to do this, but I wanted to
try it myself.

This release fixes header inclusions in
eic/irt#29
wdconinc pushed a commit to eic/eic-spack that referenced this pull request Mar 21, 2023
@c-dilks @wdconinc
irt: new version 1.0.4 (#414)
2f1557d 
### Briefly, what does this PR introduce?
@wdconinc I realize you probably have a bot to do this, but I wanted to
try it myself.

This release fixes header inclusions in
eic/irt#29
@c-dilks c-dilks mentioned this pull request May 7, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-kiselev alexander-kiselev Awaiting requested review from alexander-kiselev

@DraTeots DraTeots Awaiting requested review from DraTeots

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

File not found with <angled> include; use "quotes" instead

2 participants

@c-dilks @alexander-kiselev