fix(ci): resolve 3 desktop build failures in release workflow#314
Merged
Conversation
- Point generate-pro-provider base_path to dist/ where arch-suffixed binaries are staged, and add PARTIAL=true as a safety net for any missing platform binaries - Add electron-vite build step before electron-builder so dist/main/index.js exists when packaging - Pin VS installation path via GYP_MSVS_OVERRIDE_PATH to prevent node-gyp stdout maxBuffer overflow during VS enumeration on Windows
✅ Deploy Preview for devsydev canceled.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow is updated to refine the desktop build and release pipeline. Provider generation now operates in partial mode with a revised input path, Windows builds gain explicit Visual Studio path detection, and an electron-vite build step is inserted before packaging. ChangesDesktop Release Workflow Build Pipeline
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 pre-existing desktop build failures in the release workflow that were causing all desktop app builds (ubuntu, macOS, windows) to fail:
generate pro providerstep panicked because it looked for arch-suffixed binaries indesktop/resources/bin/(which only has the renameddevsybinary). Changed base_path todist/where arch-suffixed binaries are staged, and addedPARTIAL=trueas safety net for missing platform checksums.electron-builderfailed becausedist/main/index.jsdidn't exist. Added missingelectron-vite buildstep before electron-builder packaging.electron-rebuildduringnpm cifailed with node-gyp stdout maxBuffer overflow during VS enumeration. Addedvswhere.exeto pinGYP_MSVS_OVERRIDE_PATHdirectly, avoiding the enumeration.All 5 recent release runs showed identical failures. CLI binary builds were unaffected — only desktop builds failed.
Summary by CodeRabbit