Skip to content

fix(ci): resolve 3 desktop build failures in release workflow#314

Merged
skevetter merged 1 commit into
mainfrom
0b89-d4e9-fix-desktop-builds
May 17, 2026
Merged

fix(ci): resolve 3 desktop build failures in release workflow#314
skevetter merged 1 commit into
mainfrom
0b89-d4e9-fix-desktop-builds

Conversation

@skevetter

@skevetter skevetter commented May 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes 3 pre-existing desktop build failures in the release workflow that were causing all desktop app builds (ubuntu, macOS, windows) to fail:

  • Ubuntu: generate pro provider step panicked because it looked for arch-suffixed binaries in desktop/resources/bin/ (which only has the renamed devsy binary). Changed base_path to dist/ where arch-suffixed binaries are staged, and added PARTIAL=true as safety net for missing platform checksums.
  • macOS/all: electron-builder failed because dist/main/index.js didn't exist. Added missing electron-vite build step before electron-builder packaging.
  • Windows: electron-rebuild during npm ci failed with node-gyp stdout maxBuffer overflow during VS enumeration. Added vswhere.exe to pin GYP_MSVS_OVERRIDE_PATH directly, avoiding the enumeration.

All 5 recent release runs showed identical failures. CLI binary builds were unaffected — only desktop builds failed.

Summary by CodeRabbit

  • Chores
    • Improved desktop application build pipeline with enhanced provider generation and Windows build-tool configuration for more reliable release builds.

Review Change Stack

- Point generate-pro-provider base_path to dist/ where arch-suffixed
  binaries are staged, and add PARTIAL=true as a safety net for any
  missing platform binaries
- Add electron-vite build step before electron-builder so
  dist/main/index.js exists when packaging
- Pin VS installation path via GYP_MSVS_OVERRIDE_PATH to prevent
  node-gyp stdout maxBuffer overflow during VS enumeration on Windows
@netlify

netlify Bot commented May 17, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit a552e01
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a0a0512713c120008516565

@coderabbitai

coderabbitai Bot commented May 17, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 83ca87d9-3b7c-4c47-a183-e2afe6e5a31c

📥 Commits

Reviewing files that changed from the base of the PR and between 8a3b397 and a552e01.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release workflow is updated to refine the desktop build and release pipeline. Provider generation now operates in partial mode with a revised input path, Windows builds gain explicit Visual Studio path detection, and an electron-vite build step is inserted before packaging.

Changes

Desktop Release Workflow Build Pipeline

Layer / File(s) Summary
Pro provider generation with partial mode
.github/workflows/release.yml
The "generate pro provider" step sets PARTIAL: "true" and changes the input path argument from ../../desktop/resources/bin to ../../dist while maintaining output to dist/provider.yaml.
Windows build tools Visual Studio path detection
.github/workflows/release.yml
The "configure Windows build tools" step now invokes vswhere.exe to locate the Visual Studio installation directory and exports it as GYP_MSVS_OVERRIDE_PATH alongside GYP_MSVS_VERSION=2022.
Electron-vite build step
.github/workflows/release.yml
A new "build desktop app" step runs npx electron-vite build from the desktop working directory before the existing npx electron-builder packaging step executes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

size/m


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter skevetter marked this pull request as ready for review May 17, 2026 22:10
@skevetter skevetter merged commit 4c5cea8 into main May 17, 2026
50 checks passed
@skevetter skevetter deleted the 0b89-d4e9-fix-desktop-builds branch May 17, 2026 22:10
@coderabbitai coderabbitai Bot added the size/m label May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant