fix(ci): upload desktop artifacts via softprops/action-gh-release#326
Conversation
electron-builder's GitHub publish provider skips uploads when the release type doesn't match its expected "draft" type. release-please creates releases as prerelease (non-draft), causing the mismatch. Fix by removing the github provider from electron-builder.yml (keeping only the generic provider for dl.devsy.sh auto-update) and adding an explicit softprops/action-gh-release step to upload desktop artifacts (.dmg, .zip, .exe, .AppImage, .deb, .rpm) directly to the GitHub release — the same approach used by CLI binary and Flatpak uploads.
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe pull request reconfigures desktop release publishing by switching electron-builder from publishing directly to GitHub to a generic HTTP endpoint, while adding a GitHub Actions workflow step that separately uploads built desktop binaries (dmg, zip, exe, AppImage, deb, rpm) to GitHub Releases as draft artifacts. ChangesDesktop Release Publishing
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
githubprovider fromdesktop/electron-builder.yml— electron-builder's GitHub publish provider was silently skipping all desktop uploads due to a release type mismatch (expectsdraft, but release-please createsprerelease)softprops/action-gh-release@v3step in thebuild-desktopjob to upload desktop artifacts (.dmg, .zip, .exe, .AppImage, .deb, .rpm) directly to the GitHub releaseSummary by CodeRabbit