Skip to content

fix(ci): upload desktop artifacts via softprops/action-gh-release#326

Merged
skevetter merged 1 commit into
mainfrom
3bd4-3321-fix-desktop-artifact-upload
May 18, 2026
Merged

fix(ci): upload desktop artifacts via softprops/action-gh-release#326
skevetter merged 1 commit into
mainfrom
3bd4-3321-fix-desktop-artifact-upload

Conversation

@skevetter

@skevetter skevetter commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes the github provider from desktop/electron-builder.yml — electron-builder's GitHub publish provider was silently skipping all desktop uploads due to a release type mismatch (expects draft, but release-please creates prerelease)
  • Adds softprops/action-gh-release@v3 step in the build-desktop job to upload desktop artifacts (.dmg, .zip, .exe, .AppImage, .deb, .rpm) directly to the GitHub release
  • This fixes a bug that has existed since desktop builds were added — no release has ever had desktop artifacts uploaded by electron-builder

Summary by CodeRabbit

  • Chores
    • Updated desktop binary release publishing configuration.
    • Enhanced automated release artifact handling for desktop builds.

Review Change Stack

electron-builder's GitHub publish provider skips uploads when the
release type doesn't match its expected "draft" type. release-please
creates releases as prerelease (non-draft), causing the mismatch.

Fix by removing the github provider from electron-builder.yml (keeping
only the generic provider for dl.devsy.sh auto-update) and adding an
explicit softprops/action-gh-release step to upload desktop artifacts
(.dmg, .zip, .exe, .AppImage, .deb, .rpm) directly to the GitHub
release — the same approach used by CLI binary and Flatpak uploads.
@netlify

netlify Bot commented May 18, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 1bfc118
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a0ad8a4ee41560008937ae8

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 05482ba5-f714-4f05-9ce1-42d7a485e204

📥 Commits

Reviewing files that changed from the base of the PR and between e1ecf6b and 1bfc118.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • desktop/electron-builder.yml
💤 Files with no reviewable changes (1)
  • desktop/electron-builder.yml

📝 Walkthrough

Walkthrough

The pull request reconfigures desktop release publishing by switching electron-builder from publishing directly to GitHub to a generic HTTP endpoint, while adding a GitHub Actions workflow step that separately uploads built desktop binaries (dmg, zip, exe, AppImage, deb, rpm) to GitHub Releases as draft artifacts.

Changes

Desktop Release Publishing

Layer / File(s) Summary
Desktop release publishing configuration
desktop/electron-builder.yml, .github/workflows/release.yml
Electron-builder publish provider changes from github (with owner/repo) to generic pointing to https://dl.devsy.sh/desktop. GitHub Actions workflow adds a new step in build-desktop to upload desktop release artifacts to GitHub Releases via softprops/action-gh-release@v3 with draft status.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • devsy-org/devsy#324: Modifies .github/workflows/release.yml to adjust permissions and steps for publishing GitHub Release assets, directly supporting the main PR's new GitHub release upload behavior.
  • devsy-org/devsy#321: Modifies the same GitHub Actions release.yml workflow context, fixing Netlify metadata deployment and Flatpak-to-GitHub release uploading in the same release flow.
  • devsy-org/devsy#314: Modifies the same .github/workflows/release.yml build-desktop job sequence, adding/changing upload and packaging-related steps around electron-builder for desktop releases.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: uploading desktop artifacts via softprops/action-gh-release, which is the core fix being implemented.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter skevetter marked this pull request as ready for review May 18, 2026 09:16
@skevetter skevetter enabled auto-merge (squash) May 18, 2026 09:17
@skevetter skevetter merged commit 6a67c26 into main May 18, 2026
55 checks passed
@skevetter skevetter deleted the 3bd4-3321-fix-desktop-artifact-upload branch May 18, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant