Skip to content

fix(ci): resolve 3 desktop build failures in release workflow #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
May 17, 2026
Merged

fix(ci): resolve 3 desktop build failures in release workflow #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,17 @@ jobs:
- name: generate pro provider
if: runner.os == 'Linux'
working-directory: ./hack/pro
run: go run ./main.go ${{ inputs.tag || github.ref_name }} ../../desktop/resources/bin > ../../dist/provider.yaml
env:
PARTIAL: "true"
run: go run ./main.go ${{ inputs.tag || github.ref_name }} ../../dist > ../../dist/provider.yaml

- name: configure Windows build tools
if: runner.os == 'Windows'
shell: pwsh
run: echo "GYP_MSVS_VERSION=2022" >> $env:GITHUB_ENV
run: |
echo "GYP_MSVS_VERSION=2022" >> $env:GITHUB_ENV
$vsPath = & "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath
echo "GYP_MSVS_OVERRIDE_PATH=$vsPath" >> $env:GITHUB_ENV

- uses: actions/setup-python@v6
with:
Expand All @@ -161,6 +166,10 @@ jobs:
if: runner.os == 'Linux'
run: sudo apt-get update && sudo apt-get install -y xvfb

- name: build desktop app
working-directory: desktop
run: npx electron-vite build

- name: package and publish with electron-builder
working-directory: desktop
run: npx electron-builder ${{ matrix.builder-args }} --publish always --config electron-builder.yml
Expand Down
Loading