[WIP] The Great Streams Consolidation of 2026#6706
Draft
jasnell wants to merge 78 commits intojasnell/streams-updates-jsvaluesfrom
Draft
[WIP] The Great Streams Consolidation of 2026#6706jasnell wants to merge 78 commits intojasnell/streams-updates-jsvaluesfrom
jasnell wants to merge 78 commits intojasnell/streams-updates-jsvaluesfrom
Conversation
To fix test failures due to warning about node 20 EOL
EW-6888 Improve finishScheduled() outcome reporting
Some packages rely on this behavior. I also want to use it in workers-runtime-sdk to implement entropy hooks.
Fix typo in Python snapshot generation workflow
GC stress mode
… IO thread. The WebSocket::AutoResponse struct holds a bare kj::Promise<void> (ongoingAutoResponse) directly on the JS heap. When V8's GC collects a WebSocketPair, the destructor chain reaches this promise under DISALLOW_KJ_IO_DESTRUCTORS_SCOPE, and if the promise holds a real async node (a ForkBranch from ws.send().fork()), destroying it triggers a fatal "KJ async object being destroyed when not allowed" error (Sentry 37914510). The fix wraps the promise in kj::Maybe<IoOwn<kj::Promise<void>>> so that destruction is deferred to the IoContext's delete queue, following the same pattern already used by outgoingMessages.
ServiceWorkerGlobalScope::connect was dropping the CONNECT authority when constructing the ingress Socket, causing both socket.opened.remoteAddress and socket.opened.localAddress to resolve to undefined on the connect handler side. Plumb a localAddress parameter through Socket/setupSocket and forward the host parameter into it so JS callers see the exact authority string that was passed to fetcher.connect(...). From the handler's perspective the CONNECT authority is the local address on this side of the tunnel (the address the peer asked to connect to), not the remote address, so populate localAddress rather than remoteAddress. Outbound sockets continue to populate remoteAddress as before; localAddress remains empty for outbound since we have no useful value to expose. Extend the existing connect-handler-test with a localAddressViaServiceBinding case that asserts strict equality between the authority passed to fetcher.connect(...) and the localAddress observed on the server side.
In preparation to disable them in the future.
Tidy up python build script before 314 upgrade
…ddress fix: populate localAddress on connect handler Socket
…onse Websockets: Wrap the ongoingAutoResponse so it gets destructed on the…
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/the-great-streams-consolidation-of-2026
branch
from
cc01824 to
d60a0aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things are happening...