Skip to content

workers-sdk: Use Node 22#6697

Merged
hoodmane merged 1 commit intomainfrom
hoodmane/fix-workers-sdk-job
Apr 29, 2026
Merged

workers-sdk: Use Node 22#6697
hoodmane merged 1 commit intomainfrom
hoodmane/fix-workers-sdk-job

Conversation

@hoodmane
Copy link
Copy Markdown
Contributor

@hoodmane hoodmane commented Apr 29, 2026

To fix test failures due to warning about node 20 EOL

@hoodmane
workers-sdk: Use Node 22
076845d 
To fix test failures due to warning about node 20 EOL
@hoodmane hoodmane requested review from a team as code owners April 29, 2026 19:46
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 29, 2026

LGTM

github run

fhanau
fhanau approved these changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@fhanau fhanau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes, if workers-sdk somehow needs 20.19.6 it will tell us

@fhanau
Copy link
Copy Markdown
Contributor

fhanau commented Apr 29, 2026 •
edited
Loading

LGTM assuming CI passes, if workers-sdk somehow needs 20.19.6 it will tell us

Actually this is exactly what we should do, workers-sdk dropped support for node 20 today (cloudflare/workers-sdk#13726)

@hoodmane hoodmane enabled auto-merge (squash) April 29, 2026 20:01
@hoodmane
Copy link
Copy Markdown
Contributor Author

hoodmane commented Apr 29, 2026 •
edited
Loading

Internal CI is failing now with:

/home/gitlab-runner/.cache/bazel/_bazel_gitlab-runner/a641dcfbe29c5be8d17cc3550babf585/external/rules_rust+/util/process_wrapper/BUILD.bazel:5:36: 
Compiling Rust (without process_wrapper) bin process_wrapper (6 files) [for tool] failed:
Lost inputs no longer available remotely:
external/rules_rust++i+rules_rust_tinyjson/libtinyjson-1317710085.rlib (64f6dbaab9ba4c7044f5eb5f094d342b7f936d32e6e8a56dd09449a8b89bf5fa/430912)

Anyone know what this is about?

@hoodmane hoodmane merged commit 1f09441 into main Apr 29, 2026
29 of 30 checks passed
@hoodmane hoodmane deleted the hoodmane/fix-workers-sdk-job branch April 29, 2026 21:21
@fhanau
Copy link
Copy Markdown
Contributor

fhanau commented Apr 29, 2026

Internal CI is failing now with:

/home/gitlab-runner/.cache/bazel/_bazel_gitlab-runner/a641dcfbe29c5be8d17cc3550babf585/external/rules_rust+/util/process_wrapper/BUILD.bazel:5:36: 
Compiling Rust (without process_wrapper) bin process_wrapper (6 files) [for tool] failed:
Lost inputs no longer available remotely:
external/rules_rust++i+rules_rust_tinyjson/libtinyjson-1317710085.rlib (64f6dbaab9ba4c7044f5eb5f094d342b7f936d32e6e8a56dd09449a8b89bf5fa/430912)

Anyone know what this is about?

Looks like a transient issue possibly caused by a bazel bug – well, it has passed by now.

@hoodmane
Copy link
Copy Markdown
Contributor Author

hoodmane commented Apr 29, 2026

Got it on a few different PRs too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@jasnell jasnell jasnell approved these changes

@fhanau fhanau fhanau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoodmane @fhanau @petebacondarwin @jasnell