Merged
Conversation
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@hoodmane Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
ryanking13
approved these changes
Apr 29, 2026
Contributor
ryanking13
left a comment
ryanking13
left a comment
There was a problem hiding this comment.
Makes sense. Thanks!
However, this might introduce some change in existing workers using pth file as well. Do you think we need a compat flag?
dom96
approved these changes
Apr 29, 2026
Contributor
dom96
left a comment
dom96
left a comment
There was a problem hiding this comment.
See comment and also I agree with @ryanking13 about possible need for compat flag here
hoodmane
force-pushed
the
python-modules-process-pth-files
branch
from
20d82fc to
30df106
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6687 +/- ##
=======================================
Coverage 66.55% 66.56%
=======================================
Files 402 402
Lines 115890 115890
Branches 19405 19405
=======================================
+ Hits 77131 77138 +7
+ Misses 27188 27181 -7
Partials 11571 11571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hoodmane
force-pushed
the
python-modules-process-pth-files
branch
from
30df106 to
95dad0a
Compare
Contributor
Author
|
Okay added compat date. |
hoodmane
force-pushed
the
python-modules-process-pth-files
branch
3 times, most recently
from
75bff82 to
1725f3c
Compare
hoodmane
added a commit
to hoodmane/workers-py
that referenced
this pull request
Apr 29, 2026
…m workerd Import it in a pth file. Will take effect once cloudflare/workerd#6687 is merged and the compat flag is turned on.
hoodmane
added a commit
to hoodmane/workers-py
that referenced
this pull request
Apr 29, 2026
…m workerd Import it in a pth file. Will take effect once cloudflare/workerd#6687 is merged and the compat flag is turned on.
Some packages rely on this behavior. I also want to use it in workers-runtime-sdk to implement entropy hooks.
hoodmane
force-pushed
the
python-modules-process-pth-files
branch
from
1725f3c to
2b23217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some packages rely on this behavior. I also want to use it in workers-runtime-sdk to implement entropy hooks.