fix: update to saorsa-core 0.17.2 with peer_addrs API change#31
fix: update to saorsa-core 0.17.2 with peer_addrs API change#31mickvandijke wants to merge 3 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the crate’s release metadata and dependency constraint to align saorsa-node with a newer saorsa-core patch release.
Changes:
- Bump
saorsa-nodepackage version from0.4.0to0.4.1. - Update the
saorsa-coredependency requirement from0.17to0.17.2.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| # Core (provides EVERYTHING: networking, DHT, security, trust, storage) | ||
| saorsa-core = "0.17" | ||
| saorsa-core = "0.17.2" | ||
| saorsa-pqc = "0.5" |
Greptile SummaryThis PR bumps the Key observations:
Confidence Score: 3/5
|
| Filename | Overview |
|---|---|
| Cargo.toml | Bumps package version from 0.4.0 to 0.4.1 and changes saorsa-core from "0.17" to "0.17.2"; however, because Cargo.lock is gitignored, the constraint "0.17.2" (equivalent to ^0.17.2) does not truly pin the dependency — future patch releases like 0.17.3 can still be resolved. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[cargo build] --> B{Resolve saorsa-core}
B -->|"Cargo.toml: "0.17.2" = ^0.17.2"| C{Latest matching version?}
C -->|0.17.2 available| D[Use 0.17.2]
C -->|0.17.3 available| E[Use 0.17.3]
C -->|0.17.4 available| F[Use 0.17.4 ...]
D --> G[Build succeeds]
E --> G
F --> G
H{True pin: "=0.17.2"}
H -->|Only allows| D
I[No Cargo.lock committed] --> B
style E fill:#f9a825
style F fill:#f9a825
style H fill:#4caf50,color:#fff
Prompt To Fix All With AI
This is a comment left during a code review.
Path: Cargo.toml
Line: 31
Comment:
**Version constraint does not truly pin the dependency**
The PR title and description claim to "pin" `saorsa-core` to `0.17.2`, but the Cargo version constraint `"0.17.2"` is shorthand for `^0.17.2`, which resolves to `>=0.17.2, <0.18.0`. This means future patch releases such as `0.17.3` or `0.17.4` can still be resolved by Cargo.
Additionally, `Cargo.lock` is explicitly listed in `.gitignore` (line 66), so there is no lockfile in the repository to enforce the resolved version across builds. Each `cargo build` run could resolve a different patch version, making the dependency effectively unpinned.
To truly pin to exactly `0.17.2`, use the exact version specifier:
```suggestion
saorsa-core = "=0.17.2"
```
If the intent is only to establish `0.17.2` as the *minimum* accepted version (allowing future compatible patches), the current syntax is correct — but the PR description should clarify this distinction to avoid confusion.
How can I resolve this? If you propose a fix, please make it concise.Last reviewed commit: "chore: bump version ..."
| [dependencies] | ||
| # Core (provides EVERYTHING: networking, DHT, security, trust, storage) | ||
| saorsa-core = "0.17" | ||
| saorsa-core = "0.17.2" |
There was a problem hiding this comment.
Version constraint does not truly pin the dependency
The PR title and description claim to "pin" saorsa-core to 0.17.2, but the Cargo version constraint "0.17.2" is shorthand for ^0.17.2, which resolves to >=0.17.2, <0.18.0. This means future patch releases such as 0.17.3 or 0.17.4 can still be resolved by Cargo.
Additionally, Cargo.lock is explicitly listed in .gitignore (line 66), so there is no lockfile in the repository to enforce the resolved version across builds. Each cargo build run could resolve a different patch version, making the dependency effectively unpinned.
To truly pin to exactly 0.17.2, use the exact version specifier:
| saorsa-core = "0.17.2" | |
| saorsa-core = "=0.17.2" |
If the intent is only to establish 0.17.2 as the minimum accepted version (allowing future compatible patches), the current syntax is correct — but the PR description should clarify this distinction to avoid confusion.
Prompt To Fix With AI
This is a comment left during a code review.
Path: Cargo.toml
Line: 31
Comment:
**Version constraint does not truly pin the dependency**
The PR title and description claim to "pin" `saorsa-core` to `0.17.2`, but the Cargo version constraint `"0.17.2"` is shorthand for `^0.17.2`, which resolves to `>=0.17.2, <0.18.0`. This means future patch releases such as `0.17.3` or `0.17.4` can still be resolved by Cargo.
Additionally, `Cargo.lock` is explicitly listed in `.gitignore` (line 66), so there is no lockfile in the repository to enforce the resolved version across builds. Each `cargo build` run could resolve a different patch version, making the dependency effectively unpinned.
To truly pin to exactly `0.17.2`, use the exact version specifier:
```suggestion
saorsa-core = "=0.17.2"
```
If the intent is only to establish `0.17.2` as the *minimum* accepted version (allowing future compatible patches), the current syntax is correct — but the PR description should clarify this distinction to avoid confusion.
How can I resolve this? If you propose a fix, please make it concise.Conforms to updated `send_message` signature across the codebase to pass an empty peer addresses slice where required.
|
Reopening with renamed branch fix/stale-connections |
Implements the remaining untested scenarios from REPLICATION_DESIGN.md Section 18, bringing coverage from 47/56 to 56/56: - #20: paid-list local hit bypasses presence quorum (quorum.rs) - #22: paid-list rejection below threshold (quorum.rs) - #29: audit start gate during bootstrap (audit.rs) - #30: audit peer selection from sampled keys (audit.rs) - #31: audit periodic cadence with jitter bounds (config.rs) - #32: dynamic challenge size equals PeerKeySet (audit.rs) - #47: bootstrap claim grace period in audit path (audit.rs) - #48: bootstrap claim abuse after grace period (paid_list.rs) - #53: audit partial per-key failure with mixed responsibility (audit.rs) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Implements the remaining untested scenarios from REPLICATION_DESIGN.md Section 18, bringing coverage from 47/56 to 56/56: - #20: paid-list local hit bypasses presence quorum (quorum.rs) - #22: paid-list rejection below threshold (quorum.rs) - #29: audit start gate during bootstrap (audit.rs) - #30: audit peer selection from sampled keys (audit.rs) - #31: audit periodic cadence with jitter bounds (config.rs) - #32: dynamic challenge size equals PeerKeySet (audit.rs) - #47: bootstrap claim grace period in audit path (audit.rs) - #48: bootstrap claim abuse after grace period (paid_list.rs) - #53: audit partial per-key failure with mixed responsibility (audit.rs) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
saorsa-coredependency to0.17.2(from0.17)send_messagecalls to include the newpeer_addrsparameter added in saorsa-core 0.17.20.4.1Test plan
send_messagesignature🤖 Generated with Claude Code