fix(ci): use ubuntu-latest for test/audit/publish release jobs#30
fix(ci): use ubuntu-latest for test/audit/publish release jobs#30mickvandijke merged 2 commits intomainfrom
Conversation
ubuntu-22.04 causes glibc C23 symbol errors (__isoc23_strtol, __isoc23_sscanf) when linking lmdb-master-sys and aws-lc-sys. Only build/installer/sign jobs need ubuntu-22.04 for GLIBC 2.35 compat. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Only build and installers-linux need ubuntu-22.04 for GLIBC 2.35 compat on distributed binaries. The sign job runs only on CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the release GitHub Actions workflow to run validation/testing/audit/publish/release steps on a newer Ubuntu runner to avoid glibc/C23 symbol linker failures seen on ubuntu-22.04, while keeping artifact-building/signing steps pinned to ubuntu-22.04 for GLIBC 2.35 compatibility of distributed binaries.
Changes:
- Switch
validate,test, andsecurity-auditjobs toubuntu-latest. - Switch
publish-crateandreleasejobs toubuntu-latest. - Keep build/install/sign jobs on
ubuntu-22.04to preserve runtime compatibility targets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| validate: | ||
| name: Validate Release | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: ubuntu-latest |
Greptile SummaryThis PR fixes CI failures in
The change is well-scoped and consistent with the existing Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .github/workflows/release.yml | Five jobs migrated from ubuntu-22.04 to ubuntu-latest (validate, test, security-audit, publish-crate, release); binary-producing jobs (build, installers-linux, sign) correctly remain on ubuntu-22.04 for GLIBC 2.35 compatibility. No issues found. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["validate\n🟢 ubuntu-latest"] --> B["test\n🟢 ubuntu-latest"]
A --> C["security-audit\n🟢 ubuntu-latest"]
B --> D["build\n🔵 ubuntu-22.04 matrix"]
C --> D
A --> D
D --> E["installers-linux\n🔵 ubuntu-22.04"]
A --> F["installers-windows\nwindows-latest"]
D --> F
E --> G["sign\n🔵 ubuntu-22.04"]
F --> G
D --> G
B --> H["publish-crate\n🟢 ubuntu-latest"]
C --> H
A --> H
G --> I["release\n🟢 ubuntu-latest"]
A --> I
classDef latest fill:#22c55e,color:#fff,stroke:#16a34a
classDef focal fill:#3b82f6,color:#fff,stroke:#2563eb
classDef windows fill:#8b5cf6,color:#fff,stroke:#7c3aed
class A,B,C,H,I latest
class D,E,G focal
class F windows
Last reviewed commit: "fix(ci): switch sign..."
Implements the remaining untested scenarios from REPLICATION_DESIGN.md Section 18, bringing coverage from 47/56 to 56/56: - #20: paid-list local hit bypasses presence quorum (quorum.rs) - #22: paid-list rejection below threshold (quorum.rs) - #29: audit start gate during bootstrap (audit.rs) - #30: audit peer selection from sampled keys (audit.rs) - #31: audit periodic cadence with jitter bounds (config.rs) - #32: dynamic challenge size equals PeerKeySet (audit.rs) - #47: bootstrap claim grace period in audit path (audit.rs) - #48: bootstrap claim abuse after grace period (paid_list.rs) - #53: audit partial per-key failure with mixed responsibility (audit.rs) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Implements the remaining untested scenarios from REPLICATION_DESIGN.md Section 18, bringing coverage from 47/56 to 56/56: - #20: paid-list local hit bypasses presence quorum (quorum.rs) - #22: paid-list rejection below threshold (quorum.rs) - #29: audit start gate during bootstrap (audit.rs) - #30: audit peer selection from sampled keys (audit.rs) - #31: audit periodic cadence with jitter bounds (config.rs) - #32: dynamic challenge size equals PeerKeySet (audit.rs) - #47: bootstrap claim grace period in audit path (audit.rs) - #48: bootstrap claim abuse after grace period (paid_list.rs) - #53: audit partial per-key failure with mixed responsibility (audit.rs) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
ubuntu-latestubuntu-22.04(need GLIBC 2.35 compat for deployed binaries)Problem
The release workflow's test job failed with linker errors:
These are C23 glibc symbols referenced by
lmdb-master-sysandaws-lc-sysheaders that aren't available on ubuntu-22.04's glibc. The CI workflow (ci.yml) already usesubuntu-latestfor tests.🤖 Generated with Claude Code