Skip to content

chore: bump saorsa-core to 0.14.1 and saorsa-pqc to 0.5#20

Merged
dirvine merged 1 commit intomainfrom
chore/update-deps
Mar 9, 2026
Merged

chore: bump saorsa-core to 0.14.1 and saorsa-pqc to 0.5#20
dirvine merged 1 commit intomainfrom
chore/update-deps

Conversation

@mickvandijke
Copy link
Copy Markdown
Collaborator

Summary

  • Bump saorsa-core from 0.14.0 to 0.14.1
  • Bump saorsa-pqc from 0.4.0 to 0.5

Test plan

  • Verify cargo build --release succeeds
  • Verify cargo test passes
  • Verify node starts and connects to bootstrap peers

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings March 9, 2026 16:52
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Mar 9, 2026

Greptile Summary

This PR bumps two core dependencies: saorsa-core from 0.14.0 to 0.14.1 (a patch-level update, backward compatible) and saorsa-pqc from 0.4.0 to 0.5 (a minor version jump that is treated as a potentially breaking change under Cargo's pre-1.0 semver rules).

Key observations:

  • The saorsa-core bump is a patch release and should be safe with no API changes.
  • The saorsa-pqc 0.4.x0.5.x bump crosses a minor version boundary in a pre-1.0 crate. In Cargo's SemVer interpretation, this is a compatible-but-potentially-breaking change. The test plan items (build, tests, network connectivity) should be completed and checked off to confirm the upgrade compiles and behaves correctly.
  • The Cargo.lock file is excluded from version control via .gitignore. While this is intentional for this project, it means reproducible builds depend solely on the Cargo.toml version constraints rather than a pinned lockfile. This is a pre-existing pattern in this repo, not introduced by this PR.

Confidence Score: 4/5

  • This PR is safe to merge once the test plan (build, tests, node connectivity) is verified — the changes are minimal and well-scoped.
  • Only two dependency version lines changed. The saorsa-core patch bump is inherently safe. The saorsa-pqc minor bump may introduce breaking API changes (pre-1.0 semver), but this is easily caught by cargo build. The unchecked test plan items are the main remaining risk before merging.
  • No files require special attention beyond confirming the test plan passes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[saorsa-node v0.3.2] --> B[saorsa-core]
    A --> C[saorsa-pqc]
    B --> |before| D["saorsa-core = 0.14.0\n(>=0.14.0, <0.15.0)"]
    B --> |after| E["saorsa-core = 0.14.1\n(>=0.14.1, <0.15.0)\n✅ Patch bump — backward compatible"]
    C --> |before| F["saorsa-pqc = 0.4.0\n(>=0.4.0, <0.5.0)"]
    C --> |after| G["saorsa-pqc = 0.5\n(>=0.5.0, <0.6.0)\n⚠️ Minor bump — potentially breaking in pre-1.0"]
Loading

Last reviewed commit: a85b21e

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Rust crate dependencies for saorsa-node to pick up the latest fixes/changes from the Saorsa ecosystem libraries.

Changes:

  • Bump saorsa-core from 0.14.0 to 0.14.1
  • Bump saorsa-pqc from 0.4.0 to 0.5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Copy Markdown
Collaborator

@dirvine dirvine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mick. I checked the dependency bump and it looks good; the earlier CI failure was dependency publication timing rather than a source regression.

@dirvine dirvine merged commit 0eafb96 into main Mar 9, 2026
17 of 26 checks passed
@dirvine dirvine deleted the chore/update-deps branch March 9, 2026 17:02
mickvandijke added a commit that referenced this pull request Apr 1, 2026
Implements the remaining untested scenarios from REPLICATION_DESIGN.md
Section 18, bringing coverage from 47/56 to 56/56:

- #20: paid-list local hit bypasses presence quorum (quorum.rs)
- #22: paid-list rejection below threshold (quorum.rs)
- #29: audit start gate during bootstrap (audit.rs)
- #30: audit peer selection from sampled keys (audit.rs)
- #31: audit periodic cadence with jitter bounds (config.rs)
- #32: dynamic challenge size equals PeerKeySet (audit.rs)
- #47: bootstrap claim grace period in audit path (audit.rs)
- #48: bootstrap claim abuse after grace period (paid_list.rs)
- #53: audit partial per-key failure with mixed responsibility (audit.rs)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mickvandijke added a commit that referenced this pull request Apr 1, 2026
Implements the remaining untested scenarios from REPLICATION_DESIGN.md
Section 18, bringing coverage from 47/56 to 56/56:

- #20: paid-list local hit bypasses presence quorum (quorum.rs)
- #22: paid-list rejection below threshold (quorum.rs)
- #29: audit start gate during bootstrap (audit.rs)
- #30: audit peer selection from sampled keys (audit.rs)
- #31: audit periodic cadence with jitter bounds (config.rs)
- #32: dynamic challenge size equals PeerKeySet (audit.rs)
- #47: bootstrap claim grace period in audit path (audit.rs)
- #48: bootstrap claim abuse after grace period (paid_list.rs)
- #53: audit partial per-key failure with mixed responsibility (audit.rs)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants