Skip to content

Fix build issue on windows#357

Merged
jorisv merged 7 commits intoSimple-Robotics:develfrom
fabinsch:fix-win-build
Dec 4, 2024
Merged

Fix build issue on windows#357
jorisv merged 7 commits intoSimple-Robotics:develfrom
fabinsch:fix-win-build

Conversation

@fabinsch
Copy link
Copy Markdown
Collaborator

we encountered in the proxsuite-feedstock, here

D:\bld\proxsuite_1732720555127\work\include\proxsuite/linalg/veg/tuple.hpp(757,26): error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  757 |     return cat::template from_ref_to_result(
      |                          ^
1 warning and 1 error generated.
NMAKE : fatal error U1077: 'D:\bld\proxsuite_1732720555127\_build_env\Library\bin\cmake.exe' : return code '0x1'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
Traceback (most recent call last):
  File "C:\Miniforge\lib\site-packages\conda_build\build.py", line 2510, in build
    windows.build(
  File "C:\Miniforge\lib\site-packages\conda_build\windows.py", line 339, in build
    check_call_env(
  File "C:\Miniforge\lib\site-packages\conda_build\utils.py", line 406, in check_call_env
    return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)
  File "C:\Miniforge\lib\site-packages\conda_build\utils.py", line 382, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['cmd.exe', '/d', '/c', 'conda_build.bat']' returned non-zero exit status 1

The patch recipe/fix-windows.patch is related to content in this PR.

jorisv
jorisv previously approved these changes Nov 28, 2024
@jorisv
Copy link
Copy Markdown
Contributor

jorisv commented Dec 4, 2024

@jorisv
Copy link
Copy Markdown
Contributor

jorisv commented Dec 4, 2024

The bug is fixed in clang 19. So I installed clang from conda-forge and I changed the workflow to use this version.

@jorisv jorisv merged commit 11497f7 into Simple-Robotics:devel Dec 4, 2024
nim65s added a commit to nim65s/robotpkg that referenced this pull request Feb 3, 2026
upstream changes:

    ## [0.7.2] - 2025-03-12

    ### Fixed
    * Fix an arcane compilation issue on Clang-19 (Simple-Robotics/proxsuite#379)
    * Replace `!= None` with `is not None` in Python bindings (Simple-Robotics/proxsuite#375)
    * Fix Internal compiler error with Visual Studio 17.13 (Simple-Robotics/proxsuite#384)

    ### Changed
    * Upgrade nanobind submodule to v2.5.0 (Simple-Robotics/proxsuite#378)
    * Switch to gersemi for formatting (Simple-Robotics/proxsuite#380)
    * Switch to ruff for formatting / linting (Simple-Robotics/proxsuite#376)

    ## [0.7.1] - 2025-01-28

    ### Fixed
    * Fix Windows build with MSVC compiler and C++20 standard (Simple-Robotics/proxsuite#368)

    ## [0.7.0] - 2025-01-21

    ### Fixed
    * CMake: Fix link to system cereal in tests (Simple-Robotics/proxsuite#352)
    * Fix windows build error related to template usage in veg (Simple-Robotics/proxsuite#357)

    ### Added
    * Stub files for Python bindings, using [nanobind's native support](https://nanobind.readthedocs.io/en/latest/typing.html#stub-generation) (Simple-Robotics/proxsuite#340)
    * Python 3.13 support on PyPI (Simple-Robotics/proxsuite#361)
    * Add `solve_no_gil` for dense backend (multithreading via python) (Simple-Robotics/proxsuite#363)
    * Add benchmarks for `solve_no_gil` vs `solve_in_parallel` (openmp) (Simple-Robotics/proxsuite#363)

    ### Changed
    * Change Python bindings to use nanobind instead of pybind11 (Simple-Robotics/proxsuite#340)
    * Update setup-minicondav2 to v3 (Simple-Robotics/proxsuite#363)

    ## [0.6.7] - 2024-08-27

    ### Added
    * Fix mu update function for PrimalLDLT backend (Simple-Robotics/proxsuite#349)
    * Allow use of installed pybind11, cereal and jrl-cmakemodules via cmake
    * Add compatibility with jrl-cmakemodules workspace (Simple-Robotics/proxsuite#339)
    * Specifically mention that timings are in microseconds (Simple-Robotics/proxsuite#342)
    * Fix cereal include directory in cmake (Simple-Robotics/proxsuite#342)
    * Extend doc with hint for conda installation from source (Simple-Robotics/proxsuite#342)

    ### Fixed
    * Fix inequality constraints return in QPLayer (Simple-Robotics/proxsuite#343)

    ### Changed

    * Refactor Python examples with a new "util.py" file (Simple-Robotics/proxsuite#347)

    ## [0.6.6] - 2024-06-15

    ### Fixed
    * Fix infeasibility detection and add a unit test (Simple-Robotics/proxsuite#328)

packaging changes:

- added cereal dependency
- updated patches aa, ae
- removed patch-ab, applied upstream
nim65s added a commit to nim65s/robotpkg that referenced this pull request Feb 3, 2026
upstream changes:

    ## [0.7.2] - 2025-03-12

    ### Fixed
    * Fix an arcane compilation issue on Clang-19 (Simple-Robotics/proxsuite#379)
    * Replace `!= None` with `is not None` in Python bindings (Simple-Robotics/proxsuite#375)
    * Fix Internal compiler error with Visual Studio 17.13 (Simple-Robotics/proxsuite#384)

    ### Changed
    * Upgrade nanobind submodule to v2.5.0 (Simple-Robotics/proxsuite#378)
    * Switch to gersemi for formatting (Simple-Robotics/proxsuite#380)
    * Switch to ruff for formatting / linting (Simple-Robotics/proxsuite#376)

    ## [0.7.1] - 2025-01-28

    ### Fixed
    * Fix Windows build with MSVC compiler and C++20 standard (Simple-Robotics/proxsuite#368)

    ## [0.7.0] - 2025-01-21

    ### Fixed
    * CMake: Fix link to system cereal in tests (Simple-Robotics/proxsuite#352)
    * Fix windows build error related to template usage in veg (Simple-Robotics/proxsuite#357)

    ### Added
    * Stub files for Python bindings, using [nanobind's native support](https://nanobind.readthedocs.io/en/latest/typing.html#stub-generation) (Simple-Robotics/proxsuite#340)
    * Python 3.13 support on PyPI (Simple-Robotics/proxsuite#361)
    * Add `solve_no_gil` for dense backend (multithreading via python) (Simple-Robotics/proxsuite#363)
    * Add benchmarks for `solve_no_gil` vs `solve_in_parallel` (openmp) (Simple-Robotics/proxsuite#363)

    ### Changed
    * Change Python bindings to use nanobind instead of pybind11 (Simple-Robotics/proxsuite#340)
    * Update setup-minicondav2 to v3 (Simple-Robotics/proxsuite#363)

    ## [0.6.7] - 2024-08-27

    ### Added
    * Fix mu update function for PrimalLDLT backend (Simple-Robotics/proxsuite#349)
    * Allow use of installed pybind11, cereal and jrl-cmakemodules via cmake
    * Add compatibility with jrl-cmakemodules workspace (Simple-Robotics/proxsuite#339)
    * Specifically mention that timings are in microseconds (Simple-Robotics/proxsuite#342)
    * Fix cereal include directory in cmake (Simple-Robotics/proxsuite#342)
    * Extend doc with hint for conda installation from source (Simple-Robotics/proxsuite#342)

    ### Fixed
    * Fix inequality constraints return in QPLayer (Simple-Robotics/proxsuite#343)

    ### Changed

    * Refactor Python examples with a new "util.py" file (Simple-Robotics/proxsuite#347)

    ## [0.6.6] - 2024-06-15

    ### Fixed
    * Fix infeasibility detection and add a unit test (Simple-Robotics/proxsuite#328)

packaging changes:

- added cereal dependency
- updated patches aa, ae
- removed patch-ab, applied upstream
nim65s added a commit to nim65s/robotpkg that referenced this pull request Feb 3, 2026
upstream changes:

    ## [0.7.2] - 2025-03-12

    ### Fixed
    * Fix an arcane compilation issue on Clang-19 (Simple-Robotics/proxsuite#379)
    * Replace `!= None` with `is not None` in Python bindings (Simple-Robotics/proxsuite#375)
    * Fix Internal compiler error with Visual Studio 17.13 (Simple-Robotics/proxsuite#384)

    ### Changed
    * Upgrade nanobind submodule to v2.5.0 (Simple-Robotics/proxsuite#378)
    * Switch to gersemi for formatting (Simple-Robotics/proxsuite#380)
    * Switch to ruff for formatting / linting (Simple-Robotics/proxsuite#376)

    ## [0.7.1] - 2025-01-28

    ### Fixed
    * Fix Windows build with MSVC compiler and C++20 standard (Simple-Robotics/proxsuite#368)

    ## [0.7.0] - 2025-01-21

    ### Fixed
    * CMake: Fix link to system cereal in tests (Simple-Robotics/proxsuite#352)
    * Fix windows build error related to template usage in veg (Simple-Robotics/proxsuite#357)

    ### Added
    * Stub files for Python bindings, using [nanobind's native support](https://nanobind.readthedocs.io/en/latest/typing.html#stub-generation) (Simple-Robotics/proxsuite#340)
    * Python 3.13 support on PyPI (Simple-Robotics/proxsuite#361)
    * Add `solve_no_gil` for dense backend (multithreading via python) (Simple-Robotics/proxsuite#363)
    * Add benchmarks for `solve_no_gil` vs `solve_in_parallel` (openmp) (Simple-Robotics/proxsuite#363)

    ### Changed
    * Change Python bindings to use nanobind instead of pybind11 (Simple-Robotics/proxsuite#340)
    * Update setup-minicondav2 to v3 (Simple-Robotics/proxsuite#363)

    ## [0.6.7] - 2024-08-27

    ### Added
    * Fix mu update function for PrimalLDLT backend (Simple-Robotics/proxsuite#349)
    * Allow use of installed pybind11, cereal and jrl-cmakemodules via cmake
    * Add compatibility with jrl-cmakemodules workspace (Simple-Robotics/proxsuite#339)
    * Specifically mention that timings are in microseconds (Simple-Robotics/proxsuite#342)
    * Fix cereal include directory in cmake (Simple-Robotics/proxsuite#342)
    * Extend doc with hint for conda installation from source (Simple-Robotics/proxsuite#342)

    ### Fixed
    * Fix inequality constraints return in QPLayer (Simple-Robotics/proxsuite#343)

    ### Changed

    * Refactor Python examples with a new "util.py" file (Simple-Robotics/proxsuite#347)

    ## [0.6.6] - 2024-06-15

    ### Fixed
    * Fix infeasibility detection and add a unit test (Simple-Robotics/proxsuite#328)

packaging changes:

- added cereal dependency
- updated patches aa, ae
- removed patch-ab, applied upstream
nim65s added a commit to nim65s/robotpkg that referenced this pull request Feb 10, 2026
upstream changes:

    ## [0.7.2] - 2025-03-12

    ### Fixed
    * Fix an arcane compilation issue on Clang-19 (Simple-Robotics/proxsuite#379)
    * Replace `!= None` with `is not None` in Python bindings (Simple-Robotics/proxsuite#375)
    * Fix Internal compiler error with Visual Studio 17.13 (Simple-Robotics/proxsuite#384)

    ### Changed
    * Upgrade nanobind submodule to v2.5.0 (Simple-Robotics/proxsuite#378)
    * Switch to gersemi for formatting (Simple-Robotics/proxsuite#380)
    * Switch to ruff for formatting / linting (Simple-Robotics/proxsuite#376)

    ## [0.7.1] - 2025-01-28

    ### Fixed
    * Fix Windows build with MSVC compiler and C++20 standard (Simple-Robotics/proxsuite#368)

    ## [0.7.0] - 2025-01-21

    ### Fixed
    * CMake: Fix link to system cereal in tests (Simple-Robotics/proxsuite#352)
    * Fix windows build error related to template usage in veg (Simple-Robotics/proxsuite#357)

    ### Added
    * Stub files for Python bindings, using [nanobind's native support](https://nanobind.readthedocs.io/en/latest/typing.html#stub-generation) (Simple-Robotics/proxsuite#340)
    * Python 3.13 support on PyPI (Simple-Robotics/proxsuite#361)
    * Add `solve_no_gil` for dense backend (multithreading via python) (Simple-Robotics/proxsuite#363)
    * Add benchmarks for `solve_no_gil` vs `solve_in_parallel` (openmp) (Simple-Robotics/proxsuite#363)

    ### Changed
    * Change Python bindings to use nanobind instead of pybind11 (Simple-Robotics/proxsuite#340)
    * Update setup-minicondav2 to v3 (Simple-Robotics/proxsuite#363)

    ## [0.6.7] - 2024-08-27

    ### Added
    * Fix mu update function for PrimalLDLT backend (Simple-Robotics/proxsuite#349)
    * Allow use of installed pybind11, cereal and jrl-cmakemodules via cmake
    * Add compatibility with jrl-cmakemodules workspace (Simple-Robotics/proxsuite#339)
    * Specifically mention that timings are in microseconds (Simple-Robotics/proxsuite#342)
    * Fix cereal include directory in cmake (Simple-Robotics/proxsuite#342)
    * Extend doc with hint for conda installation from source (Simple-Robotics/proxsuite#342)

    ### Fixed
    * Fix inequality constraints return in QPLayer (Simple-Robotics/proxsuite#343)

    ### Changed

    * Refactor Python examples with a new "util.py" file (Simple-Robotics/proxsuite#347)

    ## [0.6.6] - 2024-06-15

    ### Fixed
    * Fix infeasibility detection and add a unit test (Simple-Robotics/proxsuite#328)

packaging changes:

- added cereal dependency
- updated patches aa, ae
- removed patch-ab, applied upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants