Skip to content

Refactor Python examples with a new "util.py" file#347

Merged
jcarpent merged 3 commits intoSimple-Robotics:develfrom
ManifoldFR:topic/refactor-py-examples
Aug 14, 2024
Merged

Refactor Python examples with a new "util.py" file#347
jcarpent merged 3 commits intoSimple-Robotics:develfrom
ManifoldFR:topic/refactor-py-examples

Conversation

@ManifoldFR
Copy link
Copy Markdown
Member

@ManifoldFR ManifoldFR commented Aug 13, 2024 •
edited
Loading

This PR refactors a bunch of Python examples to use a function from the same util.py file

This helps with my draft PR #345 but should have value in itself

@hrp2-14
Copy link
Copy Markdown
Member

hrp2-14 commented Aug 13, 2024

Hi ! This project doesn't usually accept pull requests on the main branch.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

@ManifoldFR ManifoldFR changed the base branch from main to devel August 13, 2024 13:53
fabinsch
fabinsch reviewed Aug 13, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fabinsch fabinsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea @ManifoldFR , thanks for the PR. I think we should address the reg and its good to merge.

Comment thread examples/python/util.py Outdated
fabinsch
fabinsch previously approved these changes Aug 13, 2024
View reviewed changes
@ManifoldFR ManifoldFR force-pushed the topic/refactor-py-examples branch from 488b874 to 91d3dc9 Compare August 13, 2024 14:26
@ManifoldFR ManifoldFR force-pushed the topic/refactor-py-examples branch from 91d3dc9 to cf43941 Compare August 13, 2024 14:27
fabinsch
fabinsch previously approved these changes Aug 13, 2024
View reviewed changes
Comment thread examples/python/util.py Outdated
@jcarpent jcarpent merged commit 315f4d3 into Simple-Robotics:devel Aug 14, 2024
@ManifoldFR ManifoldFR deleted the topic/refactor-py-examples branch August 15, 2024 21:10
nim65s added a commit to nim65s/robotpkg that referenced this pull request Feb 3, 2026
@nim65s
[optimization/{py-,}proxsuite] Update to v0.7.2
d34faa6 
upstream changes:

    ## [0.7.2] - 2025-03-12

    ### Fixed
    * Fix an arcane compilation issue on Clang-19 (Simple-Robotics/proxsuite#379)
    * Replace `!= None` with `is not None` in Python bindings (Simple-Robotics/proxsuite#375)
    * Fix Internal compiler error with Visual Studio 17.13 (Simple-Robotics/proxsuite#384)

    ### Changed
    * Upgrade nanobind submodule to v2.5.0 (Simple-Robotics/proxsuite#378)
    * Switch to gersemi for formatting (Simple-Robotics/proxsuite#380)
    * Switch to ruff for formatting / linting (Simple-Robotics/proxsuite#376)

    ## [0.7.1] - 2025-01-28

    ### Fixed
    * Fix Windows build with MSVC compiler and C++20 standard (Simple-Robotics/proxsuite#368)

    ## [0.7.0] - 2025-01-21

    ### Fixed
    * CMake: Fix link to system cereal in tests (Simple-Robotics/proxsuite#352)
    * Fix windows build error related to template usage in veg (Simple-Robotics/proxsuite#357)

    ### Added
    * Stub files for Python bindings, using [nanobind's native support](https://nanobind.readthedocs.io/en/latest/typing.html#stub-generation) (Simple-Robotics/proxsuite#340)
    * Python 3.13 support on PyPI (Simple-Robotics/proxsuite#361)
    * Add `solve_no_gil` for dense backend (multithreading via python) (Simple-Robotics/proxsuite#363)
    * Add benchmarks for `solve_no_gil` vs `solve_in_parallel` (openmp) (Simple-Robotics/proxsuite#363)

    ### Changed
    * Change Python bindings to use nanobind instead of pybind11 (Simple-Robotics/proxsuite#340)
    * Update setup-minicondav2 to v3 (Simple-Robotics/proxsuite#363)

    ## [0.6.7] - 2024-08-27

    ### Added
    * Fix mu update function for PrimalLDLT backend (Simple-Robotics/proxsuite#349)
    * Allow use of installed pybind11, cereal and jrl-cmakemodules via cmake
    * Add compatibility with jrl-cmakemodules workspace (Simple-Robotics/proxsuite#339)
    * Specifically mention that timings are in microseconds (Simple-Robotics/proxsuite#342)
    * Fix cereal include directory in cmake (Simple-Robotics/proxsuite#342)
    * Extend doc with hint for conda installation from source (Simple-Robotics/proxsuite#342)

    ### Fixed
    * Fix inequality constraints return in QPLayer (Simple-Robotics/proxsuite#343)

    ### Changed

    * Refactor Python examples with a new "util.py" file (Simple-Robotics/proxsuite#347)

    ## [0.6.6] - 2024-06-15

    ### Fixed
    * Fix infeasibility detection and add a unit test (Simple-Robotics/proxsuite#328)

packaging changes:

- added cereal dependency
- updated patches aa, ae
- removed patch-ab, applied upstream
nim65s added a commit to nim65s/robotpkg that referenced this pull request Feb 3, 2026
@nim65s
[optimization/{py-,}proxsuite] Update to v0.7.2
3c483d5 
upstream changes:

    ## [0.7.2] - 2025-03-12

    ### Fixed
    * Fix an arcane compilation issue on Clang-19 (Simple-Robotics/proxsuite#379)
    * Replace `!= None` with `is not None` in Python bindings (Simple-Robotics/proxsuite#375)
    * Fix Internal compiler error with Visual Studio 17.13 (Simple-Robotics/proxsuite#384)

    ### Changed
    * Upgrade nanobind submodule to v2.5.0 (Simple-Robotics/proxsuite#378)
    * Switch to gersemi for formatting (Simple-Robotics/proxsuite#380)
    * Switch to ruff for formatting / linting (Simple-Robotics/proxsuite#376)

    ## [0.7.1] - 2025-01-28

    ### Fixed
    * Fix Windows build with MSVC compiler and C++20 standard (Simple-Robotics/proxsuite#368)

    ## [0.7.0] - 2025-01-21

    ### Fixed
    * CMake: Fix link to system cereal in tests (Simple-Robotics/proxsuite#352)
    * Fix windows build error related to template usage in veg (Simple-Robotics/proxsuite#357)

    ### Added
    * Stub files for Python bindings, using [nanobind's native support](https://nanobind.readthedocs.io/en/latest/typing.html#stub-generation) (Simple-Robotics/proxsuite#340)
    * Python 3.13 support on PyPI (Simple-Robotics/proxsuite#361)
    * Add `solve_no_gil` for dense backend (multithreading via python) (Simple-Robotics/proxsuite#363)
    * Add benchmarks for `solve_no_gil` vs `solve_in_parallel` (openmp) (Simple-Robotics/proxsuite#363)

    ### Changed
    * Change Python bindings to use nanobind instead of pybind11 (Simple-Robotics/proxsuite#340)
    * Update setup-minicondav2 to v3 (Simple-Robotics/proxsuite#363)

    ## [0.6.7] - 2024-08-27

    ### Added
    * Fix mu update function for PrimalLDLT backend (Simple-Robotics/proxsuite#349)
    * Allow use of installed pybind11, cereal and jrl-cmakemodules via cmake
    * Add compatibility with jrl-cmakemodules workspace (Simple-Robotics/proxsuite#339)
    * Specifically mention that timings are in microseconds (Simple-Robotics/proxsuite#342)
    * Fix cereal include directory in cmake (Simple-Robotics/proxsuite#342)
    * Extend doc with hint for conda installation from source (Simple-Robotics/proxsuite#342)

    ### Fixed
    * Fix inequality constraints return in QPLayer (Simple-Robotics/proxsuite#343)

    ### Changed

    * Refactor Python examples with a new "util.py" file (Simple-Robotics/proxsuite#347)

    ## [0.6.6] - 2024-06-15

    ### Fixed
    * Fix infeasibility detection and add a unit test (Simple-Robotics/proxsuite#328)

packaging changes:

- added cereal dependency
- updated patches aa, ae
- removed patch-ab, applied upstream
nim65s added a commit to nim65s/robotpkg that referenced this pull request Feb 3, 2026
@nim65s
[optimization/{py-,}proxsuite] Update to v0.7.2
9d595f1 
upstream changes:

    ## [0.7.2] - 2025-03-12

    ### Fixed
    * Fix an arcane compilation issue on Clang-19 (Simple-Robotics/proxsuite#379)
    * Replace `!= None` with `is not None` in Python bindings (Simple-Robotics/proxsuite#375)
    * Fix Internal compiler error with Visual Studio 17.13 (Simple-Robotics/proxsuite#384)

    ### Changed
    * Upgrade nanobind submodule to v2.5.0 (Simple-Robotics/proxsuite#378)
    * Switch to gersemi for formatting (Simple-Robotics/proxsuite#380)
    * Switch to ruff for formatting / linting (Simple-Robotics/proxsuite#376)

    ## [0.7.1] - 2025-01-28

    ### Fixed
    * Fix Windows build with MSVC compiler and C++20 standard (Simple-Robotics/proxsuite#368)

    ## [0.7.0] - 2025-01-21

    ### Fixed
    * CMake: Fix link to system cereal in tests (Simple-Robotics/proxsuite#352)
    * Fix windows build error related to template usage in veg (Simple-Robotics/proxsuite#357)

    ### Added
    * Stub files for Python bindings, using [nanobind's native support](https://nanobind.readthedocs.io/en/latest/typing.html#stub-generation) (Simple-Robotics/proxsuite#340)
    * Python 3.13 support on PyPI (Simple-Robotics/proxsuite#361)
    * Add `solve_no_gil` for dense backend (multithreading via python) (Simple-Robotics/proxsuite#363)
    * Add benchmarks for `solve_no_gil` vs `solve_in_parallel` (openmp) (Simple-Robotics/proxsuite#363)

    ### Changed
    * Change Python bindings to use nanobind instead of pybind11 (Simple-Robotics/proxsuite#340)
    * Update setup-minicondav2 to v3 (Simple-Robotics/proxsuite#363)

    ## [0.6.7] - 2024-08-27

    ### Added
    * Fix mu update function for PrimalLDLT backend (Simple-Robotics/proxsuite#349)
    * Allow use of installed pybind11, cereal and jrl-cmakemodules via cmake
    * Add compatibility with jrl-cmakemodules workspace (Simple-Robotics/proxsuite#339)
    * Specifically mention that timings are in microseconds (Simple-Robotics/proxsuite#342)
    * Fix cereal include directory in cmake (Simple-Robotics/proxsuite#342)
    * Extend doc with hint for conda installation from source (Simple-Robotics/proxsuite#342)

    ### Fixed
    * Fix inequality constraints return in QPLayer (Simple-Robotics/proxsuite#343)

    ### Changed

    * Refactor Python examples with a new "util.py" file (Simple-Robotics/proxsuite#347)

    ## [0.6.6] - 2024-06-15

    ### Fixed
    * Fix infeasibility detection and add a unit test (Simple-Robotics/proxsuite#328)

packaging changes:

- added cereal dependency
- updated patches aa, ae
- removed patch-ab, applied upstream
nim65s added a commit to nim65s/robotpkg that referenced this pull request Feb 10, 2026
@nim65s
[optimization/{py-,}proxsuite] Update to v0.7.2
47ff7a1 
upstream changes:

    ## [0.7.2] - 2025-03-12

    ### Fixed
    * Fix an arcane compilation issue on Clang-19 (Simple-Robotics/proxsuite#379)
    * Replace `!= None` with `is not None` in Python bindings (Simple-Robotics/proxsuite#375)
    * Fix Internal compiler error with Visual Studio 17.13 (Simple-Robotics/proxsuite#384)

    ### Changed
    * Upgrade nanobind submodule to v2.5.0 (Simple-Robotics/proxsuite#378)
    * Switch to gersemi for formatting (Simple-Robotics/proxsuite#380)
    * Switch to ruff for formatting / linting (Simple-Robotics/proxsuite#376)

    ## [0.7.1] - 2025-01-28

    ### Fixed
    * Fix Windows build with MSVC compiler and C++20 standard (Simple-Robotics/proxsuite#368)

    ## [0.7.0] - 2025-01-21

    ### Fixed
    * CMake: Fix link to system cereal in tests (Simple-Robotics/proxsuite#352)
    * Fix windows build error related to template usage in veg (Simple-Robotics/proxsuite#357)

    ### Added
    * Stub files for Python bindings, using [nanobind's native support](https://nanobind.readthedocs.io/en/latest/typing.html#stub-generation) (Simple-Robotics/proxsuite#340)
    * Python 3.13 support on PyPI (Simple-Robotics/proxsuite#361)
    * Add `solve_no_gil` for dense backend (multithreading via python) (Simple-Robotics/proxsuite#363)
    * Add benchmarks for `solve_no_gil` vs `solve_in_parallel` (openmp) (Simple-Robotics/proxsuite#363)

    ### Changed
    * Change Python bindings to use nanobind instead of pybind11 (Simple-Robotics/proxsuite#340)
    * Update setup-minicondav2 to v3 (Simple-Robotics/proxsuite#363)

    ## [0.6.7] - 2024-08-27

    ### Added
    * Fix mu update function for PrimalLDLT backend (Simple-Robotics/proxsuite#349)
    * Allow use of installed pybind11, cereal and jrl-cmakemodules via cmake
    * Add compatibility with jrl-cmakemodules workspace (Simple-Robotics/proxsuite#339)
    * Specifically mention that timings are in microseconds (Simple-Robotics/proxsuite#342)
    * Fix cereal include directory in cmake (Simple-Robotics/proxsuite#342)
    * Extend doc with hint for conda installation from source (Simple-Robotics/proxsuite#342)

    ### Fixed
    * Fix inequality constraints return in QPLayer (Simple-Robotics/proxsuite#343)

    ### Changed

    * Refactor Python examples with a new "util.py" file (Simple-Robotics/proxsuite#347)

    ## [0.6.6] - 2024-06-15

    ### Fixed
    * Fix infeasibility detection and add a unit test (Simple-Robotics/proxsuite#328)

packaging changes:

- added cereal dependency
- updated patches aa, ae
- removed patch-ab, applied upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcarpent jcarpent jcarpent approved these changes

@fabinsch fabinsch fabinsch left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ManifoldFR @hrp2-14 @jcarpent @fabinsch