[10.0][MIG][html_image_url_extractor] Migration - #873
Merged
Conversation
Member
|
Please check Travis |
2 tasks
chienandalu
approved these changes
Jun 27, 2017
chienandalu
left a comment
chienandalu
left a comment
Member
There was a problem hiding this comment.
Review ok. Travis fail on exception logged by test as expected.
Member
|
No, Travis should be green. |
pedrobaeza
requested changes
Jul 3, 2017
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Please only silent errors before and after the affected line(s), or you will mask other possible errors.
pedrobaeza
reviewed
Jul 3, 2017
| super(ExtractorCase, self).setUp() | ||
|
|
||
| # Silent errors to keep beautiful logs and make CI pass | ||
| ir_fields_converter._logger.disable(logging.ERROR) |
Member
There was a problem hiding this comment.
This gives an error saying that Logger doesn't have disable method
Contributor
There was a problem hiding this comment.
And you could avoid this extra code since that odoo supports adds filtered logger using mute_logger
pedrobaeza
approved these changes
Jul 14, 2017
Member
|
Please squash your commits to merge. |
* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst
yajo
force-pushed
the
10.0-html_image_url_extractor
branch
from
July 17, 2017 07:41
527ab57 to
a3f38d3
Compare
Member
Author
|
squashed logically |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (15.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Tecnativa