Skip to content

[MIG] website_event_excerpt_img: Migration to 10.0 - #83

Merged
pedrobaeza merged 2 commits into
OCA:10.0from
Tecnativa:10.0-mig-website_event_excerpt_img
Aug 14, 2017
Merged

[MIG] website_event_excerpt_img: Migration to 10.0#83
pedrobaeza merged 2 commits into
OCA:10.0from
Tecnativa:10.0-mig-website_event_excerpt_img

Conversation

@chienandalu

@chienandalu chienandalu commented Jun 22, 2017

Copy link
Copy Markdown
Member

Excerpt + Image in Events

This module extends the functionality of website events to support having a
more attractive layout that automatically displays an excerpt of each one, a
"Read more" button, and an image.

It also adds a event priority control in the backend that will display the
event at the top and in a bigger shape in the website.

Depends on:

cc @Tecnativa

@yajo yajo self-assigned this Jun 23, 2017
@yajo yajo added this to the 10.0 milestone Jun 23, 2017
@pedrobaeza pedrobaeza mentioned this pull request Jun 30, 2017
7 tasks
@pedrobaeza

Copy link
Copy Markdown
Member

Please rebase and squash @yajo's commit a bit.

@chienandalu
chienandalu force-pushed the 10.0-mig-website_event_excerpt_img branch 2 times, most recently from bb891f1 to 1f30cbc Compare July 18, 2017 08:49
@pedrobaeza

Copy link
Copy Markdown
Member

Why is everything red?

@chienandalu

Copy link
Copy Markdown
Member Author

@pedrobaeza Mmm, I'll rebase again

@chienandalu
chienandalu force-pushed the 10.0-mig-website_event_excerpt_img branch from 1f30cbc to edf3c1e Compare August 8, 2017 17:40
@chienandalu

Copy link
Copy Markdown
Member Author

@pedrobaeza Well, I'm getting this warning, although these modules were merged long ago:

WARNING openerp_template odoo.modules.loading: invalid module names, ignored: html_image_url_extractor, html_text

@yajo

yajo commented Aug 9, 2017

Copy link
Copy Markdown
Member

Maybe you need server-tools in oca_requirements.txt?

@chienandalu

Copy link
Copy Markdown
Member Author

@yajo @pedrobaeza All green now

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubells please review

@cubells cubells left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captured images are not used anywhere.

You can either add them to the README file or delete them.

@cubells cubells left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LGTM

Code review and test.

yajo and others added 2 commits August 14, 2017 09:57
* Better layout for website events.
  Add event priority to display them as half or full row on website.
* Simplify dramatically removing options. All or nothing now.
  This rewrites completely the event index layout, but it was impossible to get the desired effect without that due to core design, so I simplified everything.
* Display metadata, show description below image in normal events.
* Update module name as changed in last module version.
* Avoid broken paginator layout when event number is odd.
* Use event's timezone. (OCA#57)
  Without this patch, the event's start and end dates (and times) will be inaccurate.
@pedrobaeza
pedrobaeza force-pushed the 10.0-mig-website_event_excerpt_img branch from aa6218a to 789fa5a Compare August 14, 2017 07:59
@pedrobaeza
pedrobaeza merged commit b565f8b into OCA:10.0 Aug 14, 2017
@pedrobaeza
pedrobaeza deleted the 10.0-mig-website_event_excerpt_img branch August 14, 2017 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants