[8.0][html_image_url_extractor] Image extractor from HTML fields. by yajo · Pull Request #354 · OCA/server-tools

yajo · 2016-02-10T12:08:29Z

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (OCA/website#163), or to create a slider with all images from it.

elicoidal · 2016-02-10T13:05:47Z

+        ],
+    },
+    "depends": [
+        "base",


base or website?

It makes sense to use it mostly in website, but there's no real dependency, so I'm not adding it.

yajo · 2016-02-17T10:39:50Z

Could somebody please tag this as "needs review"?

pedrobaeza · 2016-02-17T10:43:58Z

Done

sebalix · 2016-02-17T10:48:03Z

Would there be an interest to have just one module (#354 + #355) for all these kind of utilities? They both add functions to ir.fields.converter.

yajo · 2016-02-17T11:30:16Z

The ir.fields.converter is chosen just because the name somehow fits the purpose of these modules, but they really don't have much to do with the rest of that model's logic, and don't seem very related among them. But let's hear what others think.

sebalix · 2016-02-17T12:00:57Z

Yes, I was just wondering about the future if we create one module for one function. But it is probably easier to maintain/migrate like that.

pedrobaeza · 2016-04-01T22:06:52Z

Call the module html_image_url_extractor.

yajo · 2016-04-04T15:10:59Z

I already have some modules that depend on this one in production, and some PR open linked to it. If you don't mind, please let me keep the name to avoid much extra work on that. Besides, it matches the style of the just merged #355, and will be combined with it in most cases.

pedrobaeza · 2016-04-04T15:15:08Z

Sorry, but the name include plurals and it doesn't reflect the purpose of the module. Another name can be suggested, but not the original one with plural. Although now I see that the one you mention in the PR is not the most suitable, at least it doesn't contain plural.

It's very easy to change the name in your installation with openupgradelib. There's a direct method for doing it. I do it via the shell.

yajo · 2016-04-04T15:20:15Z

I decided to include plurals this time because it provides a generator, which must always be iterated.

Anyways I'm OK with what you say. Just keep in mind this will take much longer than a simple mv && git push.

This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

coveralls · 2016-04-05T11:15:09Z

Coverage increased (+0.2%) to 56.377% when pulling 7508964 on grupoesoc:html_images into d8413ed on OCA:8.0.

yajo · 2016-04-05T11:20:19Z

Module name fixed. Rebased, squashed.

pedrobaeza · 2016-04-05T11:21:53Z

+Images from HTML field
+======================
+
+This module extracts image URLs from any chunk of HTML, in appearing order.


This module includes a method that extracts...

pedrobaeza · 2016-04-05T11:22:27Z

Little comments, but 👍

coveralls · 2016-04-05T11:33:09Z

Coverage increased (+0.2%) to 56.403% when pulling b9ea2a4 on grupoesoc:html_images into d8413ed on OCA:8.0.

yajo · 2016-04-05T13:41:40Z

All fixed.

carlosdauden · 2016-04-05T17:05:58Z

👍

rafaelbn · 2016-04-12T22:55:54Z

👍 we are already using this module

rafaelbn · 2016-04-12T22:56:03Z

cc @antespi

Add an excerpt and an image taken from the post to the blog summary page. To make this work, these open PR need to be merged: - OCA/server-tools#354 - OCA/server-tools#355

[8.0][website_blog_excerpt_img] New layout for blog. Add an excerpt and an image taken from the post to the blog summary page. To make this work, these open PR need to be merged: - OCA/server-tools#354 - OCA/server-tools#355 Rephrasing. Default value for `background_image` is usually something like `http://localhost/blog/our-news-1/post/blog-post-title-3?enable_editor=1`, not empty, so fixing here to avoid failure loading empty covers. Simpler logic and better layout in phones. Fix bug in generated images, add convenient classes. The output of some images was a generator instead of an URL. I add excerpt-txt and excerpt-img classes for make life easier for themes. Add basic styling. All images now have the same height, and excerpts are 80 words long, which mostly matches the image height. Update for upstream module rename. Initial commit [IMP] Improved changing images and added backend view [ADD] Readme [FIX] New lines at end of xml files [FIX] Removed unnecessary css class [UPD] addons table in README.md [ADD] setup.py OCA Transbot updated translations from Transifex first release of website_canonical_url add a proper description correct import according to review FIX the review remarks bug fixes + add languages clean the code fix README file [FIX] remove empty section from README.rst [IMP] add pagination support [NEW][8.0] website_snippet_country_dropdown: New base module for country dropdown flags. Add demo page. CSS to Sass. Include compiled version and CSS map. Fix typo. Refactor snippet code. - The `js_country_dropdown` class is added automatically by the template. - Add `extra_class` variable to highest div element. You can set it to `has-error` for example. - Add `default_value` variable to autopopulate the inputs. - `default_country` is smarter now. Translate to Spanish. [UPD] addons table in README.md [ADD] setup.py [8.0][IMP][website_snippet_country_dropdown] Choose user's country by default. With this patch, when the currently logged-in user has a country in its profile, it will be chosen by default for the flag. [UPD] addons table in README.md Update README.rst Update README.rst OCA Transbot updated translations from Transifex Adding module website twitter no external dependencies HB connection with token working version with application token request adding formatting adding parametric support images and frontend Better data model Parametric stuff Major fix views and js fixes FIX Naming, now js is recognized Human readable name fix js error Refactoring Add theming Theming in snippet Menu Documentation Cleanup remove required Add dependency to website_parameterized_snippet flake8 better placement of menues in knowledge menu fix fix menu permissions added explicit security for therp website admin access and user access remove group, security managed on a model level access to all Feed lenght managment remove therp branding improve UL look and correct color of h5 flake8

* [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* Image extractor from HTML fields. (#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst

Add an excerpt and an image taken from the post to the blog summary page. To make this work, these open PR need to be merged: - OCA/server-tools#354 - OCA/server-tools#355

* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst

* [8.0][website_blog_excerpt_img] New layout for blog. Add an excerpt and an image taken from the post to the blog summary page. To make this work, these open PR need to be merged: - OCA/server-tools#354 - OCA/server-tools#355 * Default value for `background_image` is usually something like `http://localhost/blog/our-news-1/post/blog-post-title-3?enable_editor=1`, not empty, so fixing here to avoid failure loading empty covers. * Simpler logic and better layout in phones. Fix bug in generated images, add convenient classes. The output of some images was a generator instead of an URL. I add excerpt-txt and excerpt-img classes for make life easier for themes. Add basic styling. All images now have the same height, and excerpts are 80 words long, which mostly matches the image height. Update for upstream module rename. * OCA Transbot updated translations from Transifex * [9.0][website_blog_excerpt_img] Migrate, LGPL. Relicensed, migrated, new tests.

* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst

* [8.0][website_blog_excerpt_img] New layout for blog. Add an excerpt and an image taken from the post to the blog summary page. To make this work, these open PR need to be merged: - OCA/server-tools#354 - OCA/server-tools#355 * Default value for `background_image` is usually something like `http://localhost/blog/our-news-1/post/blog-post-title-3?enable_editor=1`, not empty, so fixing here to avoid failure loading empty covers. * Simpler logic and better layout in phones. Fix bug in generated images, add convenient classes. The output of some images was a generator instead of an URL. I add excerpt-txt and excerpt-img classes for make life easier for themes. Add basic styling. All images now have the same height, and excerpts are 80 words long, which mostly matches the image height. Update for upstream module rename. * OCA Transbot updated translations from Transifex * [9.0][website_blog_excerpt_img] Migrate, LGPL. Relicensed, migrated, new tests.

* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst

* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst OCA Transbot updated translations from Transifex

* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst

Syncing from upstream OCA/server-tools (10.0)

* Image extractor from HTML fields. (OCA#354) * [8.0][html_image_url_extractor] Image extractor from HTML fields. This technical utility allows the developer to get a list of image URLs from any piece of HTML. You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it. * [9.0] [MIG] html_image_url_extractor * Updated README.rst OCA Transbot updated translations from Transifex

elicoidal reviewed Feb 10, 2016
View reviewed changes

yajo mentioned this pull request Feb 11, 2016

[8.0][website_blog_excerpt_img] New layout for blog. OCA/website#163

Merged

pedrobaeza added the needs review label Feb 17, 2016

yajo mentioned this pull request Mar 22, 2016

[website_event_excerpt_img] Better layout for website events. OCA/event#41

Merged

2 tasks

yajo changed the title ~~[8.0][html_imgs] Image extractor from HTML fields.~~ [8.0][html_image_url_extractor] Image extractor from HTML fields. Apr 5, 2016

pedrobaeza reviewed Apr 5, 2016
View reviewed changes

Improve docs.

b9ea2a4

pedrobaeza merged commit e518a89 into OCA:8.0 May 5, 2016

yajo deleted the html_images branch May 10, 2016 07:59

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#354 from OCA/10.0

e267cf6

Syncing from upstream OCA/server-tools (10.0)

Uh oh!

Uh oh!

Conversation

yajo commented Feb 10, 2016

Uh oh!

elicoidal Feb 10, 2016

Choose a reason for hiding this comment

Uh oh!

yajo Feb 11, 2016

Choose a reason for hiding this comment

Uh oh!

yajo commented Feb 17, 2016

Uh oh!

pedrobaeza commented Feb 17, 2016

Uh oh!

sebalix commented Feb 17, 2016

Uh oh!

yajo commented Feb 17, 2016

Uh oh!

sebalix commented Feb 17, 2016

Uh oh!

pedrobaeza commented Apr 1, 2016

Uh oh!

yajo commented Apr 4, 2016

Uh oh!

pedrobaeza commented Apr 4, 2016

Uh oh!

yajo commented Apr 4, 2016

Uh oh!

coveralls commented Apr 5, 2016

Uh oh!

yajo commented Apr 5, 2016

Uh oh!

pedrobaeza Apr 5, 2016

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Apr 5, 2016

Uh oh!

coveralls commented Apr 5, 2016

Uh oh!

yajo commented Apr 5, 2016

Uh oh!

carlosdauden commented Apr 5, 2016

Uh oh!

rafaelbn commented Apr 12, 2016

Uh oh!

rafaelbn commented Apr 12, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants