[MIG] keychain to 11#5
Merged
Merged
Conversation
* Add keychain module
Readme: (in example) prefix function with _ Dep: add a depency to base_setup in order to use xml id "base.menu_config"
Remove explicit dependency to base.
…he integration of keychain when you already have /need the concept of backend
92 tasks
mart-e
force-pushed
the
11.0-mig-keychain
branch
from
October 30, 2017 16:13
00c53ca to
f337b4e
Compare
yajo
approved these changes
Oct 31, 2017
yajo
left a comment
yajo
left a comment
Member
There was a problem hiding this comment.
Code OK, at first sight, but don't merge until bots are happy.
mart-e
force-pushed
the
11.0-mig-keychain
branch
from
October 31, 2017 08:50
f337b4e to
f0a98f6
Compare
pedrobaeza
reviewed
Oct 31, 2017
| account = backend._get_existing_keychain() | ||
| self.assertEqual( | ||
| account.data, '{"a": "o", "c": "b"}', | ||
| account.get_data(), {"a": "o", "c": "b"}, |
Member
There was a problem hiding this comment.
You can use self.assertDictEqual instead for not having to worry about the order.
mart-e
force-pushed
the
11.0-mig-keychain
branch
from
November 1, 2017 08:24
3ddaf47 to
41101b6
Compare
Author
|
Is there still something to fix? The runbot error seems like a missing library to install. |
Member
|
It complains about |
Member
|
Looks pretty nice now, could you please squash all migration-related commits into one, for merging? Thanks |
Member
|
I'd squash then. Thank you very much for the contribution, Martin. |
remove coding utf8 add base_sparse_field to get Serialized fields run 2to3 bump version manual adaptation of python3
pedrobaeza
force-pushed
the
11.0-mig-keychain
branch
from
November 9, 2017 09:16
3495fea to
8038f0e
Compare
fkantelberg
pushed a commit
to initOS/server-auth
that referenced
this pull request
Jun 28, 2019
…regression;
fkantelberg
pushed a commit
to initOS/server-auth
that referenced
this pull request
Jul 8, 2019
…regression;
legalsylvain
added a commit
to legalsylvain/server-auth
that referenced
this pull request
Aug 9, 2019
dsolanki-initos
pushed a commit
to initOS/server-auth
that referenced
this pull request
Oct 22, 2020
lalithkota
pushed a commit
to lalithkota/oca-server-auth
that referenced
this pull request
Feb 25, 2024
Disable attachment for client_private_key field
moncefarajdal
pushed a commit
to moncefarajdal/server-auth
that referenced
this pull request
Oct 15, 2024
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-auth (11.0)
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-server-auth
that referenced
this pull request
Jan 13, 2025
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-server-auth
that referenced
this pull request
Jan 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to server-auth
Add base_sparse_field to get Serialized fields
Run 2to3
Bump version number
Remove coding utf-8
As it is the hacktoberfest, it is the occasion to help outside open source projects
Confession : I haven't properly tested it (yet) as I need other modules extending the module and adding
keychain.accountnamespaces.