[ADD] auth_ldaps - #6
Merged
Merged
Conversation
yajo
requested changes
Jan 30, 2018
| 'license': 'AGPL-3', | ||
| 'installable': True, | ||
| 'application': False, | ||
| 'summary': 'CB Company data', |
| class CompanyLDAP(models.Model): | ||
| _inherit = 'res.company.ldap' | ||
|
|
||
| is_ssl = fields.Boolean(string='Use LDAPS', default=False) |
Member
There was a problem hiding this comment.
This might sound like a very stupid question, but AFAIK all SSL protocols were declared as insecure nowadays. Does this work for TLS too?
|
|
||
| is_ssl = fields.Boolean(string='Use LDAPS', default=False) | ||
|
|
||
| @api.multi |
| @@ -0,0 +1,27 @@ | |||
| # © Creu Blanca | |||
| conf['ldap_server'], conf['ldap_server_port']) | ||
| connection = ldap.initialize(uri) | ||
| return connection | ||
| return super(CompanyLDAP, self).connect(conf) |
Member
There was a problem hiding this comment.
Use just super() please, it's 🐍 3️⃣ ! 😊
yajo
requested changes
Jan 30, 2018
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues | ||
| <https://github.com/OCA/{project_repo}/issues>`_. In case of trouble, please |
| ------------ | ||
|
|
||
| * Firstname Lastname <email.address@example.org> (optional company website url) | ||
| * Second Person <second.person@example.org> (optional company website url) |
|
|
||
| To install this module, you need to: | ||
|
|
||
| #. Add the certificate of the LDAP system to your server |
Member
There was a problem hiding this comment.
It's not very well explained where should it go.
etobella
force-pushed
the
11.0-add-auth_ldaps
branch
from
January 30, 2018 10:18
3476503 to
0b91beb
Compare
HviorForgeFlow
suggested changes
Jan 30, 2018
| is_ssl = fields.Boolean(string='Use LDAPS', default=False) | ||
|
|
||
| def get_ldap_dicts(self): | ||
| res = super |
Member
There was a problem hiding this comment.
This feature doesn't work. Use res = super().get_ldap_dicts()
| conf['ldap_server'], conf['ldap_server_port']) | ||
| connection = ldap.initialize(uri) | ||
| return connection | ||
| return super |
Member
There was a problem hiding this comment.
Same, Use return super().connect(conf)
etobella
force-pushed
the
11.0-add-auth_ldaps
branch
from
January 30, 2018 11:33
0b91beb to
0f32982
Compare
rgarnau
suggested changes
Feb 2, 2018
| conf['ldap_server'], conf['ldap_server_port']) | ||
| connection = ldap.initialize(uri) | ||
| return connection | ||
| return super().connect() |
There was a problem hiding this comment.
replace with return super().connect(conf)
etobella
force-pushed
the
11.0-add-auth_ldaps
branch
from
February 2, 2018 14:55
0f32982 to
049802a
Compare
Member
|
@yajo Can you update your review? |
Member
|
@hveficent can you update your review? |
yajo
approved these changes
Apr 3, 2018
fkantelberg
pushed a commit
to initOS/server-auth
that referenced
this pull request
Jun 28, 2019
…regression;
fkantelberg
pushed a commit
to initOS/server-auth
that referenced
this pull request
Jul 8, 2019
…regression;
legalsylvain
added a commit
to legalsylvain/server-auth
that referenced
this pull request
Aug 9, 2019
dsolanki-initos
pushed a commit
to initOS/server-auth
that referenced
this pull request
Oct 22, 2020
moncefarajdal
pushed a commit
to moncefarajdal/server-auth
that referenced
this pull request
Oct 15, 2024
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-auth (11.0)
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-server-auth
that referenced
this pull request
Jan 13, 2025
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-server-auth
that referenced
this pull request
Jan 18, 2025
OCA-git-bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
…-param [IMP] cross_connect_client: Work with params and not server redirect_url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LDAPS Authentication
This module allows to authenticate using a LDAP SSL system.
Installation
To install this module, you need to:
#. Add the certificate of the LDAP system to your server
Configuration
To configure this module, you need to:
#. Access Settings / General Settings / LDAP Authentication / LDAP Server
#. Check the ´Use LDAPS´ flag