[15.0][FIX] password_security: fix Policy applied to reset password dialog - #644
Merged
Merged
Conversation
ap-wtioit
force-pushed
the
15.0-fix_reset_password
branch
from
May 6, 2024 15:08
8183118 to
a6cac9b
Compare
ap-wtioit
changed the title
pedrobaeza
approved these changes
May 8, 2024
ap-wtioit
force-pushed
the
15.0-fix_reset_password
branch
from
May 8, 2024 09:52
a6cac9b to
da4bc91
Compare
wtaferner
approved these changes
May 9, 2024
Member
|
/ocabot merge minor |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 7299e4d. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add password_security settings as attributes to password input field for signup_policy.js to be able to pick them up. Also enable signup_policy.js to be loaded on /web/reset_password.
Previously the settings from password_security were not taken into consideration for the password reset form and the error message when hovering over the password strength meter always stated
Required: at least 4 characterseven when the settings where set to 12 characters or something different:Screencast from 2024-05-06 16:07:25.webm
Issue tested on runboat with: http://oca-server-auth-15-0-884f003b6318.runboat.odoo-community.org/web/reset_password?db=ba124a0ef-fd32-452f-b362-a2b0ab3b2a88&token=VZEHfqvUItBVyfAGimQu
With this change the settings from password_security are correctly applied to /web/reset_password password strenght meter.
New message is correct:
Info @wt-io-it