Fix typecheck: import getConnectedHRProvider from HRUtils#92242
Fix typecheck: import getConnectedHRProvider from HRUtils#92242MelvinBot wants to merge 1 commit into
Conversation
getConnectedHRProvider is exported from @libs/HRUtils, not @libs/PolicyUtils. TimeSensitiveSection was importing it from the wrong module, breaking the typecheck job on main. Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I analyzed the checks on this PR. There's no code fix to push — the typecheck fix in this PR works, and all CI checks pass. Status: 30 passing, 4 skipped, and 1 failing: That checklist check fails only because the PR Author Checklist boxes are unticked ( Full check breakdown
Once you complete the checklist, that last check will pass. |
|
I analyzed the checks — there's no code fix to push, every CI check passes (including The only red check is Full check breakdown
|
|
@grgia, I assume this doesn’t need a C+ review, it’s just a simple import issue, so there isn’t much to review here. |
|
@JS00001 assigning you to do secondary review 🙇 |
|
I analyzed the checks on this PR. There's no code fix to push — every code-related check passes (including The only two failing checks are:
Both are human-completed checklists, not code problems — I can't tick them on your or the reviewer's behalf. Once the author and reviewer complete their respective checklists, both checks will pass. Full check breakdown
|
|
We've already fixed this: #92245 |
Explanation of Change
The
typecheckjob started failing onmainwith:getConnectedHRProvideris defined and exported in@libs/HRUtils, not@libs/PolicyUtils.src/pages/home/TimeSensitiveSection/index.tsxwas importing it from the wrong module (every other caller in the codebase imports it from@libs/HRUtils). This is a merge-time mismatch introduced whenExpensify/App#91813landed.The fix changes the single import source from
@libs/PolicyUtilsto@libs/HRUtils. No other change is needed —PolicyUtilsis not referenced anywhere else in that file, and the import remains correctly ordered.Fixed Issues
$ #92237
PROPOSAL: #92237 (comment)
AI Tests
getConnectedHRProvideris exported fromsrc/libs/HRUtils.tsand absent fromsrc/libs/PolicyUtils.ts(grep). Import ordering remains valid (actions/connections<HRUtils<UserUtils).npm run typecheck/lint/prettier— these commands are not permitted in MelvinBot's execution environment. CItypecheck / typecheckis the authoritative gate and will validate this fix.Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionmainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari