[Payment due @brunovjk] Update Announcements widget for May 2026 product update by MelvinBot · Pull Request #91213 · Expensify/App

MelvinBot · 2026-05-20T16:03:52Z

Explanation of Change

Update the Announcements widget on the NewDot Home page for the May 2026 product update cycle:

Add new May 20 entry: "Policy upload, card freeze, and bulk editing" (Product update)
Keep existing May 6 and April 21 entries
Remove the April 15 entry

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/633940

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"

Verify that no errors appear in the JS console
Go to the Home page in New Expensify, verify the Announcements widget shows 3 entries.
Click each announcement and verify it successfully opens a URL corresponding to the announcement

Offline tests

N/A — static content change only.

QA Steps

// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review"

Verify that no errors appear in the JS console
Go to the Home page in New Expensify, verify the Announcements widget shows 3 entries.
Click each announcement and verify it successfully opens a URL corresponding to the announcement

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Add new May 20 product update entry for policy upload, card freeze, and bulk editing. Remove the April 15 entry per request. Co-authored-by: Andrew Emge <andrewemge@users.noreply.github.com>

melvin-bot · 2026-05-20T17:45:51Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify

👍

brunovjk · 2026-05-22T12:43:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-05-22T12:44:31Z

🎯 @brunovjk, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/633940.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

JmillsExpensify · 2026-05-26T14:07:38Z

What's left to get this PR merged?

brunovjk · 2026-05-26T23:39:12Z

Friendly bump @andrewemge

andrewemge · 2026-05-29T14:29:14Z

@brunovjk What are you waiting on from me?

joekaufmanexpensify · 2026-05-29T20:37:47Z

@andrewemge I think you need to fill out the PR author checklist

LLPeckham · 2026-06-01T09:23:51Z

@brunovjk - do you have everything you need from us so we can set this live today?

MelvinBot · 2026-06-01T12:59:35Z

I analyzed the checks on this PR. There's no code fix to push — all CI checks pass.

Status: 33 passing, 8 skipped, and 1 failing: PR Author Checklist / checklist.

That check fails only because the PR Author Checklist boxes are mostly unticked (You completed 5 out of 49 checklist items). This isn't a code problem — it requires the human author/co-author to review and tick the remaining boxes, which I can't do on your behalf.

Full check breakdown

✅ typecheck, ESLint check, Prettier check, React Compiler Compliance, Check for unused styles, spellcheck
✅ All 8 test (job N) shards
✅ Storybook tests, all build (...) jobs, perf-tests
✅ CLA, validate / check, verifySignedCommits, dryRun, review, checkCPlusApproval, security/snyk, license/snyk
❌ PR Author Checklist / checklist — 5/49 boxes ticked (author action required)

Once you complete the checklist, that last check will pass.

MelvinBot · 2026-06-01T13:08:02Z

I checked the CI status — all checks are now passing, so there's nothing to fix.

Status: 34 passing, 8 skipped, 0 failing.

The only non-passing check when you pinged was checklist, which was mid re-run (not failed). It has since completed successfully. All other checks — typecheck, ESLint, Prettier, all 8 test (job N) shards, Storybook tests, all build (...) jobs, perf-tests, review, validate, and verifySignedCommits — are green.

No code changes were needed.

andrewemge · 2026-06-01T13:08:28Z

@brunovjk PR Author Checklist complete, sorry about that. Should be all good to set this live today.

MelvinBot · 2026-06-01T13:10:38Z

I checked the current status of all checks on this PR — everything is passing now, there's nothing to fix.

The earlier failures were the PR Author Checklist / PR Reviewer Checklist checks, which fail until their boxes are ticked. Both have since been completed and their latest runs are green:

✅ PR Author Checklist — latest run passed (2026-06-01 13:07 UTC)
✅ PR Reviewer Checklist — latest run passed (2026-05-22 12:44 UTC)

All other checks (typecheck, all 8 test shards, ESLint, Prettier, Storybook, builds, perf-tests, etc.) are also passing. The stale checklist failures you may have seen are just earlier runs from before the checklists were filled out, not the current state.

brunovjk · 2026-06-01T13:29:27Z

Great @andrewemge, I believe we have everything we need to merge this PR? Perhaps merging main would resolve the conflicts? Thank you.

melvin-bot · 2026-06-01T15:14:15Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-06-01T15:15:00Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

andrewemge · 2026-06-01T15:15:27Z

I have read the CLA Document and I hereby sign the CLA

andrewemge · 2026-06-01T15:17:26Z

@brunovjk When the checks are done, this should be ready for you to set live.

MelvinBot · 2026-06-01T15:31:35Z

I analyzed the failing checks. None are caused by this PR — which only edits the ANNOUNCEMENTS data array in src/CONST/index.ts. So I'm not pushing a fix here. Here's the breakdown:

1. typecheck + 2. ESLint check — same pre-existing root cause (not from this PR)

src/pages/home/TimeSensitiveSection/index.tsx:17 imports getConnectedHRProvider from @libs/PolicyUtils, but that function is exported from @libs/HRUtils, not PolicyUtils. This produces TS2305: Module '"@libs/PolicyUtils"' has no exported member 'getConnectedHRProvider', and because the unresolved symbol becomes "error-typed", it cascades into the 4 ESLint no-unsafe-* errors at lines 118–126.

This file isn't touched by this PR, and the identical broken import already exists on main (SHA 3c446f7), so it's pre-existing. A dedicated fix is already open in #92242 (Fix typecheck: import getConnectedHRProvider from HRUtils).

3. test (job 8) — unrelated flaky test

tests/unit/hooks/useHasEmptyReportsForPolicy.test.ts:119 (useShouldShowEmptyReportConfirmation › updates when report data changes in Onyx) fails on a waitFor assertion (Expected: true, Received: false). This is a timing-dependent Onyx-propagation assertion, unrelated to both the announcements change and the import bug — it should pass on a re-run.

What to do: Once #92242 merges, merge main into this branch to clear typecheck + ESLint, then re-run the failed test (job 8) for the flaky test. I'm intentionally not modifying this PR, since all failures are unrelated/pre-existing.

Evidence

PR diff: only src/CONST/index.ts (ANNOUNCEMENTS entries, +6/−6).
getConnectedHRProvider is defined/exported in HRUtils.ts:43; PolicyUtils.ts does not export it (no export * re-export either).
git show origin/main:src/pages/home/TimeSensitiveSection/index.tsx line 17 → still imports from @libs/PolicyUtils on main (3c446f7), confirming the failure is not introduced by this branch.
Branch is only 1 commit behind main, and main itself carries the broken import — so merging main only helps after PR 92242 lands.

…mentsWidgetMay2026 Co-authored-by: Andrew Emge <andrewemge@users.noreply.github.com>

MelvinBot · 2026-06-01T15:54:27Z

Fixed the failing checks by merging the latest main into this branch.

Root cause: The branch was out of date with main. On main, getConnectedHRProvider was moved from @libs/PolicyUtils to @libs/HRUtils, and TimeSensitiveSection/index.tsx was updated to import from the new location. This branch still had the stale @libs/PolicyUtils import, which broke once the branch was combined with main.

This caused all three failures (none of which were in this PR's only changed file, src/CONST/index.ts):

typecheck — error TS2305: Module '"@libs/PolicyUtils"' has no exported member 'getConnectedHRProvider'.
ESLint check — 4 no-unsafe-* errors in TimeSensitiveSection/index.tsx (lines 118–126), a cascade from the unresolved import resolving to an error/any type.
test (job 8) — useHasEmptyReportsForPolicy.test.ts failed (worker force-exit); the hook/test are identical to main, so this was a flaky/cascade failure that the re-run after merging main should clear.

Fix: git merge main (no rebase). The merge was clean — after it, the branch's only diff vs main is the intended announcements update in src/CONST/index.ts, and TimeSensitiveSection now imports getConnectedHRProvider from @libs/HRUtils.

Checks are re-running now.

MelvinBot · 2026-06-01T16:02:06Z

⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.

Run details

andrewemge · 2026-06-01T20:45:19Z

@brunovjk I'm not totally sure what those last few comments from Melvin mean, but let me know if there's anything else I need to do in order for you to set this live. Thank you!

brunovjk · 2026-06-02T12:21:36Z

@andrewemge I'm not sure I can merge the PR; I think we need someone internally to do the final review and merge it. What do you think? Thanks.

andrewemge · 2026-06-02T14:04:11Z

@ahmedGaber93 Are you able to review and merge this? Let me know if I can help.

ahmedGaber93 · 2026-06-03T12:07:09Z

@andrewemge I'm a C+ as well, same as @brunovjk, so we don't have write permissions.

An internal engineer should normally be assigned automatically once @brunovjk approves this, but it looks like there may be an issue with the workflow automation. I think you could ask internally on Slack for an engineer with write access to review and merge the PR.

joekaufmanexpensify

👍

joekaufmanexpensify · 2026-06-03T12:56:36Z

We discussed me merging this here.

github-actions · 2026-06-03T12:57:08Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-03T13:04:45Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91213.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-dd0f6b462ad-59644ae-c222e02ab3449eadf64c7ee0b89adabb253c3d29/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-dd0f6b4-59644ae-2a74d5cfef7ea7653d1391c34ec3ff5a2d67abfa/index.html

Web 🕸️
https://91213.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-03T13:18:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-06-04T07:56:28Z

🚀 Deployed to staging by https://github.com/joekaufmanexpensify in version: 9.3.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-04T07:59:13Z

Help site review: no changes required

I reviewed the changes in this PR against the help site files under App/docs/articles. No documentation updates are needed.

Why: This PR is a content-only change to the ANNOUNCEMENTS array in src/CONST/index.ts — it adds the May 20 "Policy upload, card freeze, and bulk editing" product-update link, keeps the May 6 / April 21 entries, and removes the April 15 entry. It does not introduce, rename, or change any feature, UI element, tab, setting, button, or behavior.

The only help article that describes this area — Expensify-Home-Overview.md — covers the Announcements section generically ("shows recent Expensify product updates") and does not enumerate the individual announcement entries. That description remains accurate, so there is nothing to update.

Because no doc changes are required, I did not open a draft help site PR — there is no linked PR to mark Ready for review.

What I checked

Diff: only src/CONST/index.ts (ANNOUNCEMENTS list) was modified — +6 / -6 lines, swapping press-release / product-update links.
Searched App/docs/articles for announcement, home page widget, the specific announcement titles, blog URLs, and "product update" — no article lists or hard-codes the widget's announcement entries.
The Playroll / VAT-IT doc matches are unrelated accounting/connection articles, not announcement listings.

@andrewemge, no help site PR was created because the changes are content-only and don't affect documented behavior. If you'd like the new May 2026 product-update features (policy upload, card freeze, bulk editing) documented as their own help articles, let me know and I can draft those separately.

IuliiaHerets · 2026-06-04T08:17:42Z

Any QA steps here?

cc @joekaufmanexpensify @ahmedGaber93 @brunovjk @andrewemge

andrewemge · 2026-06-05T16:22:25Z

@IuliiaHerets added QA Steps

OSBotify · 2026-06-05T17:50:02Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.99-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot · 2026-06-05T17:53:30Z

🤖 Payment issue created: #92795

Update Home page Announcements widget for May 2026

c915f5e

Add new May 20 product update entry for policy upload, card freeze, and bulk editing. Remove the April 15 entry per request. Co-authored-by: Andrew Emge <andrewemge@users.noreply.github.com>

MelvinBot assigned andrewemge May 20, 2026

MelvinBot requested a review from a team May 20, 2026 16:03

andrewemge marked this pull request as ready for review May 20, 2026 17:45

andrewemge requested a review from a team as a code owner May 20, 2026 17:45

melvin-bot Bot requested review from brunovjk and joekaufmanexpensify and removed request for a team May 20, 2026 17:45

melvin-bot Bot removed the request for review from a team May 20, 2026 17:45

joekaufmanexpensify previously approved these changes May 20, 2026

View reviewed changes

brunovjk approved these changes May 22, 2026

View reviewed changes

melvin-bot Bot changed the title ~~Update Announcements widget for May 2026 product update~~ [Payment due @brunovjk] Update Announcements widget for May 2026 product update May 22, 2026

brunovjk approved these changes May 26, 2026

View reviewed changes

Merge branch 'main' into claude-updateAnnouncementsWidgetMay2026

e154f96

andrewemge dismissed joekaufmanexpensify’s stale review via e154f96 June 1, 2026 15:14

andrewemge requested a review from a team as a code owner June 1, 2026 15:14

melvin-bot Bot requested a review from ahmedGaber93 June 1, 2026 15:14

exfy-clabot Bot added a commit to Expensify/CLA that referenced this pull request Jun 1, 2026

@andrewemge has signed the CLA in Expensify/App#91213

6852611

Merge remote-tracking branch 'origin/main' into claude-updateAnnounce…

cda61cf

…mentsWidgetMay2026 Co-authored-by: Andrew Emge <andrewemge@users.noreply.github.com>

joekaufmanexpensify self-requested a review June 3, 2026 12:53

joekaufmanexpensify approved these changes Jun 3, 2026

View reviewed changes

joekaufmanexpensify merged commit dd0f6b4 into main Jun 3, 2026
35 checks passed

joekaufmanexpensify deleted the claude-updateAnnouncementsWidgetMay2026 branch June 3, 2026 12:55

github-actions Bot mentioned this pull request Jun 3, 2026

Investigate workflow job failing on main: test / test (job 6) #92504

Closed

OSBotify mentioned this pull request Jun 4, 2026

Deploy Checklist: New Expensify 2026-06-04 #92626

Closed

100 tasks

melvin-bot Bot mentioned this pull request Jun 5, 2026

[Due for payment 2026-06-12] Payment issue for E/App PR#91213 #92795

Closed

Uh oh!

Conversation

MelvinBot commented May 20, 2026 • edited by andrewemge Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 20, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

brunovjk commented May 22, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 22, 2026

Uh oh!

JmillsExpensify commented May 26, 2026

Uh oh!

brunovjk commented May 26, 2026

Uh oh!

andrewemge commented May 29, 2026

Uh oh!

joekaufmanexpensify commented May 29, 2026

Uh oh!

LLPeckham commented Jun 1, 2026

Uh oh!

MelvinBot commented Jun 1, 2026

Uh oh!

MelvinBot commented Jun 1, 2026

Uh oh!

andrewemge commented Jun 1, 2026

Uh oh!

MelvinBot commented Jun 1, 2026

Uh oh!

brunovjk commented Jun 1, 2026

Uh oh!

melvin-bot Bot commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewemge commented Jun 1, 2026

Uh oh!

andrewemge commented Jun 1, 2026

Uh oh!

MelvinBot commented Jun 1, 2026

Uh oh!

MelvinBot commented Jun 1, 2026

Uh oh!

MelvinBot commented Jun 1, 2026

Uh oh!

andrewemge commented Jun 1, 2026

Uh oh!

brunovjk commented Jun 2, 2026

Uh oh!

andrewemge commented Jun 2, 2026

Uh oh!

ahmedGaber93 commented Jun 3, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joekaufmanexpensify commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

OSBotify commented Jun 3, 2026

Uh oh!

OSBotify commented Jun 4, 2026

Uh oh!

MelvinBot commented May 20, 2026 •

edited by andrewemge

Loading

github-actions Bot commented Jun 1, 2026 •

edited

Loading